Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Add parameters deprecations to the output ofdebug:container command#51011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

HeahDude
Copy link
Contributor

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
Tickets~
LicenseMIT
Doc PR~

Since#47719 parameters can be deprecated but one needs to read the deprecation logs carefully.
It would be convenient to have the info when dumping them with debug commands.

Here's a glimpse of text format (the fixtures in tests can do the rest):

Screenshot 2023-07-18 at 12 50 49 PM

I don't know if we really want to support all formats since it may break BC somehow if parsers are used to read the output.
I still tried to adapt them all in this PR for consistency.
But JSON required an object to display both the value and the deprecation, another way could be to add a specific entry for one or all deprecations.

@carsonbotcarsonbot added this to the6.4 milestoneJul 18, 2023
@HeahDudeHeahDudeforce-pushed thefeat/debug-deprecated-parameters branch 4 times, most recently from3546512 toedd49bfCompareJuly 18, 2023 12:42
@HeahDudeHeahDudeforce-pushed thefeat/debug-deprecated-parameters branch 2 times, most recently fromfeb46c6 tof6d441dCompareJuly 24, 2023 07:18
@HeahDudeHeahDudeforce-pushed thefeat/debug-deprecated-parameters branch fromf6d441d to822b037CompareSeptember 21, 2023 08:50
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, just minor things

@HeahDudeHeahDudeforce-pushed thefeat/debug-deprecated-parameters branch 2 times, most recently from365ebc8 to41e1d2cCompareOctober 7, 2023 09:02
@HeahDudeHeahDudeforce-pushed thefeat/debug-deprecated-parameters branch from41e1d2c to5e06203CompareOctober 11, 2023 07:39
@fabpot
Copy link
Member

Thank you@HeahDude.

HeahDude and Enz000 reacted with heart emoji

@fabpotfabpotforce-pushed thefeat/debug-deprecated-parameters branch from5e06203 to7963e9dCompareOctober 11, 2023 07:44
@fabpotfabpot merged commit4e16f7b intosymfony:6.4Oct 11, 2023
@HeahDudeHeahDude deleted the feat/debug-deprecated-parameters branchOctober 11, 2023 07:45
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

4 participants
@HeahDude@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp