NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Routing] adding typehint to some functions and parameters#51005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

helyakin wants to merge3 commits intosymfony:6.4fromhelyakin:chores/updatingRoutingTypehint

Closed

[Routing] adding typehint to some functions and parameters#51005

helyakin wants to merge3 commits intosymfony:6.4fromhelyakin:chores/updatingRoutingTypehint

Conversation

Copy link

helyakin commentedJul 17, 2023

Q	A
Branch?	6.4
Bug fix?	no
New feature?	no
Deprecations?	no

So i was walking around the Routing component for diverse reasons, and I came across some not type hinted:

Function
Parameter

I've also taken the freedom to add the property accessibility into the constructor since we are using php81

I have absolutely no idea if this PR is welcome, as this might be something you would not want to add to this framework for now.

Feel free to share your thoughts and opinions about this PR, I'll gladly learn whatever you might say about it !

Thanks again for your time

[Routing] adding typehint to some functions and parameters

177349a

carsonbot added Status: Needs Review Routing labels

Jul 17, 2023

carsonbot added this to the6.4 milestone

Jul 17, 2023

Marvin Courcier added2 commits

July 17, 2023 22:44

updating route anotation typehint functions

8b112e1

adding back nullable to strictRequirements typehint

5d1050b

Copy link

Member

wouterj commentedJul 17, 2023

Hi!

Adding a return type is a backwards compatibility break for child classes overriding this method. In 6.4, all methods have either a PHP return type or an@return PHPdoc (#47551,#50821). This results in a deprecation notices when you override a method without adding the correct PHP return type. In 7.0, we've added all missing return types (#50852,#50846) - except from some that we want to extend for another 2 years to avoid a big burden on the community.

For the same reasons, we've also limited property types to private or internal properties, or properties on final or internal classes (see#41924 for a bit more context).

Finally, I'm not sure what our policy is with CPP. I'm not too fond of it, as it's merely syntax sugar and can cause edge-case BC breaks as well:#45721 (comment)