Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] DeprecateStopWorkerOnSignalsListener#50997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@HypeMC
Copy link
Member

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?yes
Tickets-
LicenseMIT
Doc PR-

Followup to#50787.

@xabbuh
Copy link
Member

StopWorkerOnSigtermSignalListener should be updated as well. It would currently reference the now deprecated class.

@HypeMCHypeMCforce-pushed thedeprecate-stop-worker-on-signals-listener branch 3 times, most recently from9fad606 tofbcda78CompareJuly 17, 2023 07:51
@HypeMC
Copy link
MemberAuthor

@xabbuh Done. Not sure about the pslam error, it shouldn't be a problem.

@HypeMCHypeMCforce-pushed thedeprecate-stop-worker-on-signals-listener branch fromfbcda78 to0b62ce8CompareJuly 19, 2023 19:33
@nicolas-grekas
Copy link
Member

Thank you@HypeMC.

@nicolas-grekasnicolas-grekas merged commit40d61eb intosymfony:6.4Jul 19, 2023
@HypeMCHypeMC deleted the deprecate-stop-worker-on-signals-listener branchJuly 19, 2023 19:46
@nicolas-grekas
Copy link
Member

PR welcome on 7.0 for the cleanup 🙏

@xabbuh
Copy link
Member

xabbuh commentedJul 20, 2023•
edited
Loading

Looking at what would need to be cleaned up in 7.0 I stumbled upon thestop_worker_on_signals messenger config option which until now modifies theStopWorkerOnSignalsListener constructor arguments. Shouldn't this part of theFrameworkExtension have been updated in this PR too?

@HypeMC
Copy link
MemberAuthor

HypeMC commentedJul 21, 2023•
edited
Loading

@xabbuh No, thestop_worker_on_signals config will be used in certain commands, see#50787.

nicolas-grekas added a commit that referenced this pull requestJul 26, 2023
…er` (HypeMC)This PR was merged into the 7.0 branch.Discussion----------[Messenger] Remove deprecated `StopWorkerOnSignalsListener`| Q             | A| ------------- | ---| Branch?       | 7.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Followup to#50997.Commits-------4366044 [Messenger] Remove deprecated `StopWorkerOnSignalsListener`
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

4 participants

@HypeMC@xabbuh@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp