Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Fix fetching lazy non-shared services multiple times with as filestrue#50996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[DependencyInjection] Fix fetching lazy non-shared services multiple times with as filestrue#50996
Uh oh!
There was an error while loading.Please reload this page.
Conversation
213940b toa12184cCompare…times with as files true
a12184c tocb434a4Compare| ->register('foo',Foo::class) | ||
| ->register('foo',\Bar\FooLazyClass::class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A minor mistake I made in my original PR, doesn't really change anything, but it makes the test a bit more consistent.
| $lastDump =array_pop($dumps); | ||
| foreach (array_reverse($dumps)as$dump) { | ||
| eval('?>'.$dump); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is there a better way to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nah, that's fine
nicolas-grekas commentedJul 19, 2023
Thank you@HypeMC. |
Followup to#50985, fixes case when
as_filesistrue.This particular problem exists only on v6.3 and was introduced in#48469.