Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Fix fetching lazy non-shared services multiple times#50985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:6.2fromHypeMC:fix-fetching-of-lazy-non-shared-servicesJul 16, 2023
Merged
[DependencyInjection] Fix fetching lazy non-shared services multiple times#50985
nicolas-grekas merged 1 commit intosymfony:6.2fromHypeMC:fix-fetching-of-lazy-non-shared-servicesJul 16, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
9ad3a37 tof35d0f2CompareMember
nicolas-grekas commentedJul 16, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for having a look. I checked why the id could come as first argument and I think the fix we need is this one: --- a/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php+++ b/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php@@ -900,6 +900,8 @@ EOF; if ($asFile) { $code .= "fn () => self::do(\$container);\n\n";+ } elseif ($definition->isPublic()) {+ $code .= sprintf("fn() => \$this->%s();\n\n", $methodName); } else { $code .= sprintf("\$this->%s(...);\n\n", $methodName); } WDYT? |
f35d0f2 toef2626fCompareMember
nicolas-grekas commentedJul 16, 2023
Thank you@HypeMC. |
MemberAuthor
HypeMC commentedJul 16, 2023
@nicolas-grekas There's one more case this doesn't cover, see#50996 . |
nicolas-grekas added a commit that referenced this pull requestJul 19, 2023
…ces multiple times with as files `true` (HypeMC)This PR was merged into the 6.3 branch.Discussion----------[DependencyInjection] Fix fetching lazy non-shared services multiple times with as files `true`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#50975| License | MIT| Doc PR | -Followup to#50985, fixes case when `as_files` is `true`.This particular problem exists only on v6.3 and was introduced in#48469.Commits-------cb434a4 [DependencyInjection] Fix fetching lazy non-shared services multiple times with as files true
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt tofix#50975.