Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[VarDumper] Fix dumpingArrayObject withDumpDataCollector#50960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 2 commits intosymfony:5.4fromHypeMC:fix-dumping-arrayobject
Jul 13, 2023

Conversation

@HypeMC
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#50940
LicenseMIT
Doc PR-

The main problem here is that theArrayObjectstorage key inthe array returned by__debugInfo() seems to be a reference:https://3v4l.org/8rSFn (a bug in PHP perhaps?)

Since theDumpDataCollector does the actual dumping in the__destructor() theArrayObjectstorage is modified by then which messes with the object created by theVarCloner.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice thanks!

@HypeMCHypeMCforce-pushed thefix-dumping-arrayobject branch from1058e35 tob25f377CompareJuly 13, 2023 07:33
Copy link
Member

@lyrixxlyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah! Thanks

@nicolas-grekas
Copy link
Member

Thank you@HypeMC.

@nicolas-grekasnicolas-grekas merged commit23da9db intosymfony:5.4Jul 13, 2023
@HypeMCHypeMC deleted the fix-dumping-arrayobject branchJuly 13, 2023 09:22
This was referencedJul 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@lyrixxlyrixxlyrixx approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@HypeMC@nicolas-grekas@lyrixx@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp