Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpKernel] Skip corrupted CSV data in FileProfilerStorage#50947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@radar3301
Copy link
Contributor

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsPartiallyfixes#50942, improves/fixes on PR#50913, partially fixes#50816
LicenseMIT

Technically, part of this fix could go all the way back to 2.1, but since we're not sure why/how exactly the index.csv file is being corrupted in the first place, this PR should just serve as a stop-gap measure until the root cause can be identified.

A corrupted index.csv file is especially noticeable since 6.3, when the "Remove Expired Profiles" feature was added by#47352 .

RE: improves/fixes on PR#50913:
Warnings are (usually?) only escalated to errors in debug mode, so having a try/catch is a bit more overhead than I think is actually needed, and I believe just checking that the line read from the csv is not corrupted is the better/faster option. Granted, the profiler should really only be active in debug/non-production modes anyway, but "should" and reality usually don't align...

@alamirault@MatTheCat@benjaminfunk@Pelagoss@derrabus

@carsonbotcarsonbot added this to the6.3 milestoneJul 12, 2023
@radar3301radar3301 changed the titleUpdate FileProfilerStorage.php[HttpKernel] Update FileProfilerStorage.phpJul 12, 2023
@derrabus
Copy link
Member

Thank you. Please pick a more meaningful PR title and add a test.

@radar3301radar3301 changed the title[HttpKernel] Update FileProfilerStorage.php[HttpKernel] Ignore corrupted CSV data in FileProfilerStorageJul 12, 2023
@radar3301
Copy link
ContributorAuthor

radar3301 commentedJul 12, 2023
edited
Loading

Thank you. Please pick a more meaningful PR title

Done. No idea how I didn't see that.

and add a test.

Sorry, but I'm not going to write 50+ lines of code of unit test for such a trivial 2 LoC sanity check...

@radar3301radar3301 changed the title[HttpKernel] Ignore corrupted CSV data in FileProfilerStorage[HttpKernel] Skip corrupted CSV data in FileProfilerStorageJul 12, 2023
fix "Undefined array key" by skipping invalid/corrupted lines
@nicolas-grekasnicolas-grekasforce-pushed the6.3-file-profiler-storage branch fromd30f689 tob4e942dCompareJuly 13, 2023 14:33
@nicolas-grekas
Copy link
Member

Thank you@radar3301.

radar3301 reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commit201ad71 intosymfony:6.3Jul 13, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

4 participants

@radar3301@derrabus@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp