Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Intl] Taking into account bibliographic + overlong#50943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromoleg-andreyev:issue_50142
Jul 13, 2023

Conversation

@oleg-andreyev
Copy link
Contributor

@oleg-andreyevoleg-andreyev commentedJul 11, 2023•
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#50142
LicenseMIT
Doc PR-

When building Alpha3 and aliases take into accountbibliographic type.

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "5.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@oleg-andreyevoleg-andreyev changed the base branch from6.4 to5.4July 11, 2023 20:18
@oleg-andreyev
Copy link
ContributorAuthor

@oleg-andreyevoleg-andreyev changed the titleIssue 50142[Intl] Taking into account bibliographic + overlongJul 11, 2023
@oleg-andreyev
Copy link
ContributorAuthor

Copy link
Member

@stofstof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

shouldn'tgenerateAlpha3Codes be updated to include them as well ?

@oleg-andreyev
Copy link
ContributorAuthor

shouldn'tgenerateAlpha3Codes be updated to include them as well ?

I agree with@ro0NL, T codes are preferable, B are considered legacy.

#50943 (comment)

@oleg-andreyev
Copy link
ContributorAuthor

I'll squash commits before merge.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(please squash if you can yes)

oleg-andreyev reacted with thumbs up emoji
@carsonbotcarsonbot changed the title[Intl] Taking into account bibliographic + overlongTaking into account bibliographic + overlongJul 13, 2023
@oleg-andreyev
Copy link
ContributorAuthor

(please squash if you can yes)

One commit is related to update-data on MacOS (fix)
Second is actually about this ticket.

I hope it's okay (prefer more or less clean and separate history)

@nicolas-grekas
Copy link
Member

We always squash so that one PR=one commit. This is the same topic :)

oleg-andreyev reacted with thumbs up emoji

@oleg-andreyev
Copy link
ContributorAuthor

We always squash so that one PR=one commit. This is the same topic :)

Not a problem, now one commit.

@carsonbotcarsonbot changed the titleTaking into account bibliographic + overlong[Intl] Taking into account bibliographic + overlongJul 13, 2023
@nicolas-grekas
Copy link
Member

Thank you@oleg-andreyev.

oleg-andreyev reacted with rocket emoji

@nicolas-grekasnicolas-grekas merged commita056e7b intosymfony:5.4Jul 13, 2023
@oleg-andreyevoleg-andreyev deleted the issue_50142 branchJuly 13, 2023 09:07
This was referencedJul 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@wouterjwouterjAwaiting requested review from wouterj

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@ro0NLro0NLAwaiting requested review from ro0NL

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[Intl] nl language can be represented as dut and nld

5 participants

@oleg-andreyev@carsonbot@nicolas-grekas@stof@ro0NL
[8]ページ先頭
©2009-2025 Movatter.jp