Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Addduplicate_preferred_choices option toChoiceType#50934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@arnaud-deabreu
Copy link
Contributor

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#35135
LicenseMIT
Doc PRTODO

I've reintroduced layout tests as they were before#32658, is that enough? /cc@xabbuh :)
Thanks@HeahDude for your mentoring!

HeahDude, MirakuSan, welcoMattic, Valmonzo, feymo, asrorbekh, and damien-louis reacted with heart emojijeremyFreeAgent, Valmonzo, feymo, and asrorbekh reacted with eyes emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@arnaud-deabreuarnaud-deabreuforce-pushed thefeature/preferred_choice_deduplicate branch 2 times, most recently from927aed0 to33a89bfCompareJuly 11, 2023 10:00
@arnaud-deabreuarnaud-deabreuforce-pushed thefeature/preferred_choice_deduplicate branch from33a89bf to5b5d18dCompareJuly 24, 2023 07:12
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for taking care of this,@javiereguiluz should like it :)

javiereguiluz reacted with thumbs up emoji
@arnaud-deabreuarnaud-deabreuforce-pushed thefeature/preferred_choice_deduplicate branch from5b5d18d to3b48abaCompareAugust 3, 2023 14:11
@nicolas-grekasnicolas-grekasforce-pushed thefeature/preferred_choice_deduplicate branch from3b48aba todf00a5fCompareSeptember 29, 2023 09:51
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(failures unrelated)

@fabpot
Copy link
Member

Thank you@arnaud-deabreu.

jeremyFreeAgent and arnaud-deabreu reacted with heart emoji

@fabpotfabpot merged commit8b420d4 intosymfony:6.4Oct 5, 2023
fabpot added a commit that referenced this pull requestOct 16, 2023
… choices (HeahDude)This PR was merged into the 7.0 branch.Discussion----------[Form] Remove deprecation layer for duplicated preferred choices| Q             | A| ------------- | ---| Branch?       | 7.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | ~| License       | MITFollows#50934.Commits-------8945228 [Form] Remove deprecation layer for duplicated preferred choices
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

[Form] Allow disabling of preferred_choices being shown twice

4 participants

@arnaud-deabreu@carsonbot@fabpot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp