IIRC we overrode the tests in other cases. But we should add a comment that the overridden methods can be removed in the7.0 branch.

Thanks@xabbuh, hope I did it correctly

Is it still time to merge this in 6.4 or will I have to rebase on 7.1 when the branch will be created?

we should have a test ensuring that passingnull explicitly (to not have any default protocol) works without triggering a deprecation. Otherwise it will make it impossible to have that behavior (which is the wanted one when you want an<input type="url">) without triggering a deprecation.

@stof thanks for the review 🙏

Do you know how I can test whether a given code does not trigger a deprecation?

@MatTheCat Don't put the@group legacy on the test, and the phpunit bridge will already make the test fail if it triggers a deprecation.
But looking at the test file in full (not visible in the diff of the PR), we already have some tests passingnull explicitly so this will be fine.

You should add a test that runs into the situation, and if it triggers a deprecation, the CI will fail.

Thank you@MatTheCat.