Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel][WebProfilerBundle] Fix search feature#50913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
GromNaN commentedJul 7, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It looks like you're trying to hide a problem in |
Pelagoss commentedJul 8, 2023
I think it only occurs when the file is very big. Or maybe when multiple client requests the backend at same time |
MatTheCat commentedJul 9, 2023
The root issue seems to be the same as#50816. |
Pelagoss commentedJul 10, 2023
I will try with 6.3 and let you know |
Pelagoss commentedJul 10, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/HttpKernel/Profiler/FileProfilerStorage.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
33778bb tocffceb1Comparenicolas-grekas commentedJul 13, 2023
Thank you@Pelagoss. |
…age (radar3301)This PR was merged into the 6.3 branch.Discussion----------[HttpKernel] Skip corrupted CSV data in FileProfilerStorage| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | Partiallyfixes#50942, improves/fixes on PR#50913, partially fixes#50816| License | MITTechnically, part of this fix could go all the way back to 2.1, but since we're not sure why/how exactly the index.csv file is being corrupted in the first place, this PR should just serve as a stop-gap measure until the root cause can be identified.A corrupted index.csv file is especially noticeable since 6.3, when the "Remove Expired Profiles" feature was added by#47352 .RE: improves/fixes on PR#50913:Warnings are (usually?) only escalated to errors in debug mode, so having a try/catch is a bit more overhead than I think is actually needed, and I believe just checking that the line read from the csv is not corrupted is the better/faster option. Granted, the profiler should really only be active in debug/non-production modes anyway, but "should" and reality usually don't align...`@alamirault` `@MatTheCat` `@benjaminfunk` `@Pelagoss` `@derrabus`Commits-------b4e942d Update FileProfilerStorage.php


This fix research feature in the profiler.
Sometimes lines in index.csv are broken with something like this :
,,200
the try and catch allow the profiler to skip these lines