Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Enhance exception if possible#50911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromlyrixx:error-enhancer
Jul 30, 2023

Conversation

lyrixx
Copy link
Member

@lyrixxlyrixx commentedJul 7, 2023•
edited
Loading

QA
Branch?6.4
Bug fix?no
New feature?restore an old feature
Deprecations?no
Tickets
LicenseMIT
Doc PR

I don't know if it's the best place to do that.
I think in the kernel, it would be better, WDYT?

Before

image

After :

image

@lyrixx
Copy link
MemberAuthor

lyrixx commentedJul 8, 2023•
edited
Loading

I really wonder if the controller is the best place to do that

  • If one use a custom controller, it won't work
  • I should also add support for the console components, right?

@lyrixx
Copy link
MemberAuthor

I updated the PR

  • IntroducedErrorHandler::enchanceError()
  • Move the call from the ErrorController to the ErrorListener (this is more global like this)

@lyrixx
Copy link
MemberAuthor

There were 15 errors:1) Symfony\Component\HttpKernel\Tests\EventListener\ErrorListenerTest::testHandleWithoutLogger with data set #0 (Symfony\Component\HttpKernel\Event\ExceptionEvent Object (...), Symfony\Component\HttpKernel\Event\ExceptionEvent Object (...))Error: Call to undefined method Symfony\Component\ErrorHandler\ErrorHandler::enhanceError()

tests are KO because the new code does not exist yet in 7.0?

@yceruto
Copy link
Member

tests are KO because the new code does not exist yet in 7.0?

I think after synchronizing with 7.0 it should be fixed

@fabpot
Copy link
Member

Thank you@lyrixx.

@fabpotfabpot merged commit48b0d9d intosymfony:6.4Jul 30, 2023
@lyrixxlyrixx deleted the error-enhancer branchJuly 30, 2023 17:31
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull requestSep 6, 2023
…ixx)This PR was merged into the 6.4 branch.Discussion----------[HttpKernel] Enhance exception if possible| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | restore an old feature| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |I don't know if it's the best place to do that.I think in the kernel, it would be better, WDYT?Before![image](https://github.com/symfony/symfony/assets/408368/e2a452aa-b669-4598-8b23-5366c5b80a74)After :![image](https://github.com/symfony/symfony/assets/408368/0e30c50d-5c94-43db-a9e5-19be6ccd5f2b)Commits-------2bfb9d9 [HttpKernel] Enhance exception if possible
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@GromNaNGromNaNGromNaN left review comments

@stofstofstof approved these changes

@fabpotfabpotfabpot approved these changes

@ycerutoycerutoyceruto approved these changes

@fancywebfancywebfancyweb approved these changes

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

8 participants
@lyrixx@yceruto@fabpot@nicolas-grekas@GromNaN@stof@fancyweb@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp