NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DepdencyInjection] Fix costly logic when checking errored definitions#50905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromnicolas-grekas:di-fix-errored-check

Jul 7, 2023

Merged

[DepdencyInjection] Fix costly logic when checking errored definitions#50905

nicolas-grekas merged 1 commit intosymfony:5.4fromnicolas-grekas:di-fix-errored-check

Jul 7, 2023

Conversation

Copy link

Member

nicolas-grekas commentedJul 6, 2023•
edited
Loading

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#50763 (comment)
License	MIT
Doc PR	-

@NicolJamie @X-Coder264 can you please give this patch a try and report back. Does that fix the perf issue you're having?

carsonbot added Status: Needs Review Bug labels

Jul 6, 2023

carsonbot added this to the5.4 milestone

Jul 6, 2023

nilBora reviewed

Jul 6, 2023

View reviewed changes

src/Symfony/Component/DependencyInjection/Compiler/DefinitionErrorExceptionPass.php OutdatedShow resolvedHide resolved

Copy link

Contributor

X-Coder264 commentedJul 6, 2023•
edited
Loading

@nicolas-grekas It does fix it, thanks.

Without this fix:

www-data@31ed4ece830c:/srv/app$ time bin/console ca:clPHP Fatal error:  Allowed memory size of 1073741824 bytes exhausted (tried to allocate 163840 bytes) in /srv/app/vendor/symfony/dependency-injection/Compiler/DefinitionErrorExceptionPass.php on line 69PHP Fatal error:  Uncaught Symfony\Component\ErrorHandler\Error\OutOfMemoryError: Error: Allowed memory size of 1073741824 bytes exhausted (tried to allocate 163840 bytes) in /srv/app/vendor/symfony/dependency-injection/Compiler/DefinitionErrorExceptionPass.php:69Stack trace:#0 {main}  thrown in /srv/app/vendor/symfony/dependency-injection/Compiler/DefinitionErrorExceptionPass.php on line 69www-data@31ed4ece830c:/srv/app$ time bin/console ca:clPHP Fatal error:  Allowed memory size of 1073741824 bytes exhausted (tried to allocate 163840 bytes) in /srv/app/vendor/symfony/dependency-injection/Compiler/DefinitionErrorExceptionPass.php on line 69PHP Fatal error:  Uncaught Symfony\Component\ErrorHandler\Error\OutOfMemoryError: Error: Allowed memory size of 1073741824 bytes exhausted (tried to allocate 163840 bytes) in /srv/app/vendor/symfony/dependency-injection/Compiler/DefinitionErrorExceptionPass.php:69Stack trace:#0 {main}  thrown in /srv/app/vendor/symfony/dependency-injection/Compiler/DefinitionErrorExceptionPass.php on line 69real    1m0.200suser    0m59.713ssys     0m0.464s

With this fix:

www-data@31ed4ece830c:/srv/app$ time bin/console ca:clIn DefinitionErrorExceptionPass.php line 49:                                                                                                                                                                                                           Cannot autowire service "foo": argument "$bar" of method "Baz::__construct()" is type-hinted "int", you should confi    gure its value explicitly.                                                                                                                                                                                                                                                                                                                                                                                     real    0m9.052suser    0m8.738ssys     0m0.308s