NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Add native return types to fix compat with v7#50890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.4fromnicolas-grekas:compat-v7

Jul 6, 2023

Merged

Add native return types to fix compat with v7#50890

nicolas-grekas merged 1 commit intosymfony:6.4fromnicolas-grekas:compat-v7

Jul 6, 2023

Conversation

Copy link

Member

nicolas-grekas commentedJul 5, 2023

Q	A
Branch?	6.4
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

nicolas-grekas requested review fromchalasr,lyrixx,wouterj,xabbuh andyceruto ascode owners

July 5, 2023 14:02

carsonbot added the Status: Needs Review label

Jul 5, 2023

carsonbot added this to the6.4 milestone

Jul 5, 2023

nicolas-grekas force-pushed thecompat-v7 branch fromf669935 toeefd660Compare

July 5, 2023 14:04

nicolas-grekas requested a review fromdunglas as acode owner

July 5, 2023 14:04

stof reviewed

Jul 5, 2023

View reviewed changes

src/Symfony/Component/Form/Extension/Validator/Constraints/FormValidator.php OutdatedShow resolvedHide resolved

nicolas-grekas force-pushed thecompat-v7 branch 3 times, most recently frome7c4be9 to133bb13Compare

July 5, 2023 14:43

derrabus reviewed

Jul 5, 2023

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Tests/Kernel/ConcreteMicroKernel.phpShow resolvedHide resolved

src/Symfony/Bundle/FrameworkBundle/Tests/Kernel/flex-style/src/FlexStyleMicroKernel.phpShow resolvedHide resolved

nicolas-grekas force-pushed thecompat-v7 branch 6 times, most recently frome9fef32 to404ea2fCompare

July 6, 2023 06:22

Add native return types to fix compat with v7

0590ec1

nicolas-grekas force-pushed thecompat-v7 branch from404ea2f to0590ec1Compare

July 6, 2023 07:01

nicolas-grekas commented

Jul 6, 2023

View reviewed changes

Copy link

MemberAuthor

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

All green, PR is ready.

What this does is adding a few return types on some selected classes on 6.4.
Technically, this is a BC break, but I think the patched methods have a very low chance of being overridden in a child class.

Note that while preparing this PR, I reverted some native return types on 7.0 as well, see full list in:
https://github.com/symfony/symfony/blob/7.0/.github/expected-missing-return-types.diff

Alternatively to this PR, we could revert more native return types on 7.0, and we could also declare v6 and v7 as being incompatible for the related packages. This is a matter of finding the sweet spot between those approaches, and this PR is my proposal :)

I'm merging it now to unlock the CI, but feel free to discuss the topic even after merge, we still have a few months to adjust this before the release.