Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Deprecate not configuring thedefault_protocol option of theUrlType#50882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2b543bd tob99f459Compare… if they have skipped properties
Member
yceruto commentedJul 6, 2023
Hi@MatTheCat, can you check your commit? it looks unrelated to this PR's proposal. |
ContributorAuthor
MatTheCat commentedJul 9, 2023
Damn seems I’ve been mixing up my branches 😬 Opened#50922 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
You would expect an
<input type="url">from theUrlType, but it is not possible as long asdefault_protocolhas a value, because then you have to accept inputs that are not URLs (and you get an<input type="text" inputmode="url">).In order to change
default_protocolfrom'http'tonullin 7.0, we must first deprecate not configuring it.Don’t know how I can update tests though; all of
UrlTypeTest’s parent test cases will trigger the deprecation 🤔