NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Notifier] support local development for sns by adding sslmode option#50879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.4fromFerror:notifier-sns-sslmode

Aug 1, 2023

Merged

[Notifier] support local development for sns by adding sslmode option#50879

fabpot merged 1 commit intosymfony:6.4fromFerror:notifier-sns-sslmode

Aug 1, 2023

Conversation

Copy link

Contributor

Ferror commentedJul 4, 2023

Q	A
Branch?	6.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	none
License	MIT
Doc PR	symfony/symfony-docs#...

When developing locally with AWS -> localstack we have to communicate via HTTP similarly to the SQS Transport for Messenger component.

https://github.com/symfony/amazon-sqs-messenger/blob/6.3/Transport/Connection.php#L50C14-L50C14

Ferror requested a review fromOskarStark as acode owner

July 4, 2023 19:45

carsonbot added Status: Needs Review Feature Notifier labels

Jul 4, 2023

carsonbot added this to the6.4 milestone

Jul 4, 2023

Copy link

carsonbot commentedJul 4, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot