Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[7.0] Remove remaining deprecated code paths#50873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:7.0fromnicolas-grekas:all-deprec
Jul 5, 2023

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?7.0
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Form

  • Throw when usingDateTime orDateTimeImmutable model data with a different timezone than configured with the
    model_timezone option inDateType,DateTimeType, andTimeType
  • Make the "widget" option of date/time form types default to "single_text"

FrameworkBundle

  • Make thehttp_method_override config option default tofalse
  • RemoveAbstractController::renderForm(), userender() instead
  • Remove theSymfony\Component\Serializer\Normalizer\ObjectNormalizer and
    Symfony\Component\Serializer\Normalizer\PropertyNormalizer autowiring aliases, type-hint against
    Symfony\Component\Serializer\Normalizer\NormalizerInterface or implementNormalizerAwareInterface instead
  • Remove theHttp\Client\HttpClient service, usePsr\Http\Client\ClientInterface instead

Messenger

  • RemoveMessageHandlerInterface andMessageSubscriberInterface, use#[AsMessageHandler] instead
  • RemoveStopWorkerOnSigtermSignalListener in favor of
    StopWorkerOnSignalsListener and make it configurable with SIGINT and
  • RemoveSymfony\Component\Messenger\Transport\InMemoryTransport and
    Symfony\Component\Messenger\Transport\InMemoryTransportFactory in favor of
    Symfony\Component\Messenger\Transport\InMemory\InMemoryTransport and
    Symfony\Component\Messenger\Transport\InMemory\InMemoryTransportFactory

Translation

  • RemovePhpStringTokenParser
  • RemovePhpExtractor in favor ofPhpAstExtractor

TwigBundle

  • Remove optiontwig.autoescape, usetwig.autoescape_service[_method] instead
  • Remove theTwig_Environment autowiring alias, useTwig\Environment instead

Yaml

  • Remove the!php/const: tag, use!php/const instead (without the colon)

* @internal since Symfony 6.1
* @internal
*/
trait ServerLogHandlerTrait
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@lyrixx@Seldaek WDYT of removing support for monolog < 3?

lyrixx reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes that would allow some conditional code mess to be cleaned up which sounds great

lyrixx reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@lyrixx up for a PR doing so?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm on it

$container->services()
->set('annotations.reader', AnnotationReader::class)
->call('addGlobalIgnoredName', ['required'])// @deprecated since Symfony 6.3
->call('addGlobalIgnoredName', ['required'])
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

keeping this as is so that ppl can still use the annotation without being bothered

wouterj reacted with thumbs up emoji
Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀 Nice one

Some UPGRADE guide suggestions, I haven't looked at the code changes.

@lyrixx
Copy link
Member

You forgot to update the CHANGELOG of the workflow component (a least this one)

@nicolas-grekasnicolas-grekasforce-pushed theall-deprec branch 6 times, most recently fromf07fb6f to048170fCompareJuly 4, 2023 15:29
nicolas-grekas added a commit that referenced this pull requestJul 4, 2023
…-grekas)This PR was merged into the 6.4 branch.Discussion----------[6.4] Fix remainings from previous deprecations| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Found while working on#50873Commits-------2d59b2f [6.4] Fix remainings from previous deprecations
nicolas-grekas added a commit that referenced this pull requestJul 5, 2023
…scriptors (nicolas-grekas)This PR was merged into the 5.4 branch.Discussion----------[Messenger] Fix passing options set via tags to handler descriptors| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Spotted while working on#50873Commits-------2a6f72b [Messenger] Fix passing options set via tags to handler descriptors
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjwouterj left review comments

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@lyrixxlyrixxAwaiting requested review from lyrixxlyrixx is a code owner

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

@jderussejderusseAwaiting requested review from jderussejderusse is a code owner

+1 more reviewer

@SeldaekSeldaekSeldaek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas@lyrixx@Seldaek@wouterj@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp