Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[7.0] Remove remaining deprecated code paths#50873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * @internal since Symfony 6.1 | ||
| * @internal | ||
| */ | ||
| trait ServerLogHandlerTrait |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes that would allow some conditional code mess to be cleaned up which sounds great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@lyrixx up for a PR doing so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm on it
| $container->services() | ||
| ->set('annotations.reader', AnnotationReader::class) | ||
| ->call('addGlobalIgnoredName', ['required'])// @deprecated since Symfony 6.3 | ||
| ->call('addGlobalIgnoredName', ['required']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
keeping this as is so that ppl can still use the annotation without being bothered
wouterj left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚀 Nice one
Some UPGRADE guide suggestions, I haven't looked at the code changes.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
lyrixx commentedJul 4, 2023
You forgot to update the CHANGELOG of the workflow component (a least this one) |
f07fb6f to048170fCompare…-grekas)This PR was merged into the 6.4 branch.Discussion----------[6.4] Fix remainings from previous deprecations| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Found while working on#50873Commits-------2d59b2f [6.4] Fix remainings from previous deprecations
…scriptors (nicolas-grekas)This PR was merged into the 5.4 branch.Discussion----------[Messenger] Fix passing options set via tags to handler descriptors| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Spotted while working on#50873Commits-------2a6f72b [Messenger] Fix passing options set via tags to handler descriptors
Form
DateTimeorDateTimeImmutablemodel data with a different timezone than configured with themodel_timezoneoption inDateType,DateTimeType, andTimeTypeFrameworkBundle
http_method_overrideconfig option default tofalseAbstractController::renderForm(), userender()insteadSymfony\Component\Serializer\Normalizer\ObjectNormalizerandSymfony\Component\Serializer\Normalizer\PropertyNormalizerautowiring aliases, type-hint againstSymfony\Component\Serializer\Normalizer\NormalizerInterfaceor implementNormalizerAwareInterfaceinsteadHttp\Client\HttpClientservice, usePsr\Http\Client\ClientInterfaceinsteadMessenger
MessageHandlerInterfaceandMessageSubscriberInterface, use#[AsMessageHandler]insteadStopWorkerOnSigtermSignalListenerin favor ofStopWorkerOnSignalsListenerand make it configurable with SIGINT andSymfony\Component\Messenger\Transport\InMemoryTransportandSymfony\Component\Messenger\Transport\InMemoryTransportFactoryin favor ofSymfony\Component\Messenger\Transport\InMemory\InMemoryTransportandSymfony\Component\Messenger\Transport\InMemory\InMemoryTransportFactoryTranslation
PhpStringTokenParserPhpExtractorin favor ofPhpAstExtractorTwigBundle
twig.autoescape, usetwig.autoescape_service[_method]insteadTwig_Environmentautowiring alias, useTwig\EnvironmentinsteadYaml
!php/const:tag, use!php/constinstead (without the colon)