NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Components] Convert to native return types#50852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:7.0fromwouterj:convert-to-native-types-2

Jul 5, 2023

Merged

[Components] Convert to native return types#50852

nicolas-grekas merged 1 commit intosymfony:7.0fromwouterj:convert-to-native-types-2

Jul 5, 2023

Conversation

Copy link

Member

wouterj commentedJul 2, 2023•
edited by nicolas-grekas
Loading

Q	A
Branch?	7.0
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

wouterj requested review fromchalasr,dunglas,jderusse,lyrixx,xabbuh andyceruto ascode owners

July 2, 2023 21:56

carsonbot added Status: Needs Work and removed Status: Needs Work labels

Jul 2, 2023

carsonbot added this to the7.0 milestone

Jul 2, 2023

carsonbot added the Status: Needs Review label

Jul 2, 2023

Copy link

Member

nicolas-grekas commentedJul 3, 2023

rebase unlocked + some fixes needed I guess

nicolas-grekas changed the title~~[WIP] [Components] Convert to native return types~~[Components] Convert to native return types

Jul 5, 2023

nicolas-grekas force-pushed theconvert-to-native-types-2 branch frome3220b5 to824f48aCompare

July 5, 2023 12:38

nicolas-grekas requested a review fromOskarStark as acode owner

July 5, 2023 12:38

nicolas-grekas mentioned this pull request

Jul 5, 2023

[Security] Add native return type toFirewall::getSubscribedEvents()#50889

Merged

nicolas-grekas added a commit that referenced this pull request

Jul 5, 2023

minor#50889[Security] Add native return type to `Firewall::getSubsc…

e869eb6

…ribedEvents()` (nicolas-grekas)This PR was merged into the 6.4 branch.Discussion----------[Security] Add native return type to `Firewall::getSubscribedEvents()`| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Required to make#50852 green without breaking compat between v6 and v7.Commits-------8069f49 [Security] Add native return type to `Firewall::getSubscribedEvents()`

[Components] Convert to native return types

a250774

nicolas-grekas force-pushed theconvert-to-native-types-2 branch from824f48a toa250774Compare

July 5, 2023 13:06

nicolas-grekas approved these changes

Jul 5, 2023

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I finished the PR.

I order to help third party bundles to be compatible with Symfony 7, I didn't add thevoid return type to the following interfaces (all listed in.github/expected-missing-return-types.diff):

src/Symfony/Component/DependencyInjection/Compiler/CompilerPassInterface.php
src/Symfony/Component/DependencyInjection/Extension/PrependExtensionInterface.php
src/Symfony/Component/HttpKernel/Bundle/BundleInterface.php

Please open an issue or send a PR if you think we should add more interfaces to this list.

Note that src/Symfony/Contracts/Service/ResetInterface.php also doesn't have a native type, and that's on purpose, to keep compatibility with implementations that do have a return value.

I also patched DebugClassLoader so that it doesn't skipvoid return types.