Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Bridges][Bundles] Convert to native return types#50846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
wouterj commentedJul 2, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
For reference, commands to automate 90% of these changes: # convert typessed -i's/ *"\*\*\/Tests\/"//' composer.jsoncomposer u -oSYMFONY_PATCH_TYPE_DECLARATIONS='force=2&php=8.2' php .github/patch-types.phpgit checkout composer.json# cleanupgit diff-tree --no-commit-id --name-only HEAD -r| xargs -L1 ./tools/php-cs-fixer/vendor/bin/php-cs-fixer fix --rules phpdoc_trim_consecutive_blank_line_separation,no_superfluous_phpdoc_tags,ordered_imports,no_empty_phpdoc,no_whitespace_in_blank_line,no_extra_blank_lines,phpdoc_trim_consecutive_blank_line_separationgit diff-tree --no-commit-id --name-only HEAD -r| xargs -L1 sed -i':a;N;$!ba;s/{\n\n/{\n/' |
8a07748 to45060bdCompare45060bd tof90d2a9CompareMember
nicolas-grekas commentedJul 3, 2023
Thank you@wouterj. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first batch of many. This is I think the easiest one: bundles and bridges contain classes that almost never get extended by third party packages. As such, I've converted all types (including void) to native ones.
For the components, we should probably split up non-void types (easy merges) and void types (need close reviews).