Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[SecurityBundle] Do not translateBearer header’serror_description#50819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.2fromMatTheCat:ticket_50811
Jun 29, 2023

Conversation

@MatTheCat
Copy link
Contributor

@MatTheCatMatTheCat commentedJun 29, 2023•
edited
Loading

QA
Branch?6.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#50811
LicenseMIT
Doc PRN/A

FromRFC 6750:

the "error_description" attribute [provides] a human-readable explanation that is not meant to be displayed to end-users.

Not translating it avoids non-ASCII characters inBearer’s value, which in turn avoid messing withRFC 8187 (fun read; thanks@derrabus!).

Not sure if and how this should be tested 🤔

derrabus reacted with thumbs up emoji
@carsonbotcarsonbot changed the title[Security] Does not translateBearer header’serror_description[SecurityBundle] Does not translateBearer header’serror_descriptionJun 29, 2023
@nicolas-grekasnicolas-grekas changed the title[SecurityBundle] Does not translateBearer header’serror_description[SecurityBundle] Do not translateBearer header’serror_descriptionJun 29, 2023
@nicolas-grekas
Copy link
Member

Thank you@MatTheCat.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@derrabusderrabusderrabus approved these changes

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

5 participants

@MatTheCat@nicolas-grekas@stof@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp