NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Scheduler] Fix`PeriodicalTrigger` from argument for stateful run dates#50818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.3fromStanJansen:fix/scheduler_periodical_trigger_stateful_next_run_date

Jul 5, 2023

Merged

[Scheduler] Fix`PeriodicalTrigger` from argument for stateful run dates#50818

nicolas-grekas merged 1 commit intosymfony:6.3fromStanJansen:fix/scheduler_periodical_trigger_stateful_next_run_date

Jul 5, 2023

Conversation

Copy link

Contributor

StanJansen commentedJun 29, 2023

Q	A
Branch?	6.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#50669
License	MIT
Doc PR	-

Summary: Unless you provide thefrom argument (with a date in the past), caching will not work for thePeriodicalTrigger.

If thefrom argument is not passed to theRecurringMessage::every method, it will, fallback tonew \DateTimeImmutable(). If you use a stateful schedule and you restart the consumer (either manually or using a time limit), the cached last-executed date will always be overridden by the moment you restart the scheduler due toif ($this->from > $run) {.

StanJansen requested a review fromkbond as acode owner

June 29, 2023 08:31

carsonbot added Status: Needs Review Bug Scheduler labels

Jun 29, 2023

carsonbot added this to the6.3 milestone

Jun 29, 2023

Copy link

carsonbot commentedJun 29, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

OskarStark changed the title~~[Scheduler] Fix PeriodicalTrigger from argument for stateful run dates~~[Scheduler] FixPeriodicalTrigger from argument for stateful run dates

Jun 30, 2023