Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] Allow custom working directory in TestHttpServer#50814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ro0NL wants to merge0 commits intosymfony:6.4fromro0NL:patch-1
Closed

[HttpClient] Allow custom working directory in TestHttpServer#50814

ro0NL wants to merge0 commits intosymfony:6.4fromro0NL:patch-1

Conversation

ro0NL
Copy link
Contributor

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix #...
LicenseMIT
Doc PRsymfony/symfony-docs#...

eases mocking by a lot :)

@carsonbotcarsonbot added this to the6.4 milestoneJun 28, 2023
@ro0NLro0NL changed the title[HttpClient] Make test server extensible[HttpClient] Make test server reusableJun 28, 2023
@ro0NL
Copy link
ContributorAuthor

ro0NL commentedJun 28, 2023•
edited
Loading

with this enabled we could think of new frameworkbundle config, to route all clients to the test server, so we guarantee no external traffic occurs

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

needs something in the changelog

@ro0NLro0NL changed the title[HttpClient] Make test server reusable[HttpClient] Allow custom working directory for TestHttpServerJun 29, 2023
@ro0NLro0NL changed the title[HttpClient] Allow custom working directory for TestHttpServer[HttpClient] Allow custom working directory in TestHttpServerJun 29, 2023
@fabpot
Copy link
Member

Thank you@ro0NL.

fabpot added a commit that referenced this pull requestJun 30, 2023
…pServer (ro0NL)This PR was squashed before being merged into the 6.4 branch.Discussion----------[HttpClient] Allow custom working directory in TestHttpServer| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->eases mocking by a lot :)Commits-------c8f1f9a [HttpClient] Allow custom working directory in TestHttpServer
@fabpotfabpot closed thisJun 30, 2023
@ro0NLro0NL deleted the patch-1 branchJune 30, 2023 06:36
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@fabpotfabpotfabpot approved these changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

5 participants
@ro0NL@fabpot@javiereguiluz@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp