NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpClient] Add an HAR response factory for testing#50807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:7.0fromGaryPEGEOT:feat/har-response-factory

Jul 9, 2023

Merged

[HttpClient] Add an HAR response factory for testing#50807

fabpot merged 1 commit intosymfony:7.0fromGaryPEGEOT:feat/har-response-factory

Jul 9, 2023

Conversation

Copy link

Contributor

GaryPEGEOT commentedJun 28, 2023•
edited
Loading

Q	A
Branch?	6.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets
License	MIT
Doc PR	TODO

From the network tab of most modern browsers, you can save one or more request as an HAR archive file. This pull request adds a way to use those files in test to replay responses previously saved.

Example usage:

// Inside a KernelTestCase// ...$factory =newHarFileResponseFactory('path/to/some_file.har');static::getContainer()->get('http_client')->setResponseFactory($factory);// Will find the suitable response(s) inside some_file.har$myServiceWithHttpCalls->doSomething();

carsonbot added Status: Needs Review Feature HttpClient labels

Jun 28, 2023

carsonbot added this to the6.4 milestone

Jun 28, 2023

Nyholm reviewed

Jun 28, 2023

View reviewed changes

Copy link

Member

Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you.

If the HAR file can contain multiple request/responses. Then I suggestyielding. That means we can do:

$factory =newHarFileResponseFactory($myHarFile);$client =newMockHttpClient($factory);

src/Symfony/Component/HttpClient/Test/HarFileResponseFactory.phpShow resolvedHide resolved

Nyholm approved these changes

Jun 30, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jun 30, 2023

fabpot approved these changes

Jul 9, 2023

View reviewed changes

src/Symfony/Component/HttpClient/Test/HarFileResponseFactory.php Outdated

		$json = json_decode(
		json: file_get_contents($this->archiveFile),
		associative: true,
		flags: \JSON_THROW_ON_ERROR

Copy link

Member

fabpotJul 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	flags: \JSON_THROW_ON_ERROR
	flags: \JSON_THROW_ON_ERROR,

Copy link

Member

fabpotJul 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's be consistent with the code base and use the "short" version here on one line.

Copy link

ContributorAuthor

GaryPEGEOTJul 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed!

fabpot modified the milestones:6.4,7.0

Jul 9, 2023

Copy link

Member

fabpot commentedJul 9, 2023

Can you rebase on 7.0 and add a note in the CHANGELOG?

GaryPEGEOT requested review fromOskarStark,chalasr,dunglas,jderusse,kbond,lyrixx,wouterj,xabbuh andyceruto ascode owners

July 9, 2023 10:22

carsonbot added Status: Needs Review and removed Status: Reviewed labels

Jul 9, 2023

GaryPEGEOT changed the base branch from6.4 to7.0

July 9, 2023 10:23

fabpot reviewed

Jul 9, 2023

View reviewed changes

src/Symfony/Component/HttpClient/Test/HarFileResponseFactory.phpShow resolvedHide resolved

fabpot approved these changes

Jul 9, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jul 9, 2023

[HttpClient] Add an HAR response factory for testing

01d2e35

Copy link

Member

fabpot commentedJul 9, 2023

Thank you@GaryPEGEOT.

fabpot merged commitc63faff intosymfony:7.0

Jul 9, 2023

fabpot mentioned this pull request

Jul 9, 2023

[HttpClient] Add an HAR response factory for testingsymfony/symfony-docs#18546

Closed

GaryPEGEOT deleted the feat/har-response-factory branch

July 9, 2023 11:16

nicolas-grekas modified the milestones:7.0,6.4

Jul 20, 2023

fabpot mentioned this pull request

Oct 21, 2023

Release v7.0.0-BETA1#52224

Merged

Labels

Feature HttpClient Status: Reviewed

6 participants

Movatterモバイル変換

Uh oh!

[HttpClient] Add an HAR response factory for testing#50807

[HttpClient] Add an HAR response factory for testing#50807

Uh oh!

Conversation

GaryPEGEOT commentedJun 28, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Nyholm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fabpotJul 9, 2023

Choose a reason for hiding this comment

Uh oh!

fabpotJul 9, 2023

Choose a reason for hiding this comment

Uh oh!

GaryPEGEOTJul 9, 2023

Choose a reason for hiding this comment

Uh oh!

fabpot commentedJul 9, 2023

Uh oh!

Uh oh!

fabpot commentedJul 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

GaryPEGEOT commentedJun 28, 2023•
edited
Loading