NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Serializer] Fix Normalizer not utilizing converted name for index variadic param#50804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromDidierLmn:fix-denormalize-variadic-constructor-parameter-with-name-converter

Jul 7, 2023

Merged

[Serializer] Fix Normalizer not utilizing converted name for index variadic param#50804

nicolas-grekas merged 1 commit intosymfony:5.4fromDidierLmn:fix-denormalize-variadic-constructor-parameter-with-name-converter

Jul 7, 2023

Conversation

Copy link

Contributor

DidierLmn commentedJun 28, 2023

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

The AbstractNormalizer uses the wrong array index when setting variadic constructor parameters. It checks if the$key index (which is the normalized name) exists, but then tries to access the$paramName index (which is non-normalized name).

This becomes an issue when using a custom NameConverter, for example one that switches between PascalCase and camelCase.

DidierLmn requested a review fromdunglas as acode owner

June 28, 2023 10:08

carsonbot added Status: Needs Review Bug Serializer labels

Jun 28, 2023

carsonbot added this to the5.4 milestone

Jun 28, 2023

Copy link

carsonbot commentedJun 28, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

carsonbot changed the title~~[Serializer] Fix Normalizer not utilizing converted name for index variadic param~~[Serializer] Fix Normalizer not utilizing converted name for index variadic param

Jun 28, 2023