Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Fix regression with class metadatada on parent classes#50788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromrmikalkenas:ticket_50780
Jul 20, 2023

Conversation

@rmikalkenas
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#50780
LicenseMIT

garak, ottaviano, and kontsevoye reacted with thumbs up emojidmaicher and TheMilek reacted with rocket emoji
@carsonbotcarsonbot added this to the5.4 milestoneJun 27, 2023
@rmikalkenasrmikalkenas marked this pull request as draftJune 27, 2023 06:57
@rmikalkenasrmikalkenasforce-pushed theticket_50780 branch 3 times, most recently from05b8978 to60bd664CompareJune 27, 2023 13:15
@rmikalkenasrmikalkenas marked this pull request as ready for reviewJune 27, 2023 13:53
@rmikalkenas
Copy link
ContributorAuthor

Unit Tests / Unit Tests (8.2, high-deps) - looks like failingTimezoneValidatorTest::testValidTimezones with data set #9 ('America/Montreal') is unrelated with the changes.

Unit Tests / Unit Tests (8.2, low-deps) -DoctrineLoaderTest::testLoadClassMetadata failing, becausedoctrineMetadata->fieldMappings does not contain DoctrineLoaderParentEntity::publicParentMaxLength field. Could it be due to some doctrine bug in lower versions..? Need some help with this one

cc@nicolas-grekas

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For deps=high, the failure is a false positive.
For deps=low, it's something we need to figure out.

I force-pushed a minor change, seehttps://github.com/symfony/symfony/compare/60bd66422334099482c110206619eb54cd187c0a..2ba0f57c655ab9921cbaeeb2c60bdb7de781f23c

You can reproduce the issue locally by requiring orm~2.15.0:

COMPOSER_ROOT_VERSION=5.4.x-dev composer require --dev doctrine/orm:~2.15.0./phpunit src/Symfony/Bridge/Doctrine/ --filter testLoadClassMetadata

Does this help?

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I figured out the proper fix on DoctrineLoader.

@nicolas-grekas
Copy link
Member

Thank you@rmikalkenas.

rmikalkenas reacted with hooray emoji

@nicolas-grekasnicolas-grekas merged commit5f08512 intosymfony:5.4Jul 20, 2023
This was referencedJul 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@rmikalkenas@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp