Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Fix exitingmessenger:failed:retry command#50787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:6.3fromHypeMC:fix-exiting-failedmessagesretrycommandSep 29, 2023
Merged
[Messenger] Fix exitingmessenger:failed:retry command#50787
nicolas-grekas merged 1 commit intosymfony:6.3fromHypeMC:fix-exiting-failedmessagesretrycommandSep 29, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2627b1b toe5ddf86CompareUh oh!
There was an error while loading.Please reload this page.
e5ddf86 to54c97a4CompareHypeMC commentedJul 11, 2023
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
HypeMC commentedJul 11, 2023
Uh oh!
There was an error while loading.Please reload this page.
HypeMC commentedJul 11, 2023
Uh oh!
There was an error while loading.Please reload this page.
This was referencedJul 11, 2023
Member
lyrixx left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like it.
- Could you deprecate the listener
- And the service associated with
- Add a note in the changelog
- Add a note in the upgrade guide?
Thanks
fabpot added a commit that referenced this pull requestJul 13, 2023
…messenger:failed:retry` command (HypeMC)This PR was merged into the 5.4 branch.Discussion----------[FrameworkBundle] Add missing monolog channel tag to the `messenger:failed:retry` command| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Noticed this while working on#50787, similar to#49843.Commits-------8f30c1e [FrameworkBundle] Add missing monolog channel tag to the `messenger:failed:retry` command
nicolas-grekas added a commit that referenced this pull requestJul 13, 2023
…hout the Console component (HypeMC)This PR was merged into the 5.4 branch.Discussion----------[DebugBundle][FrameworkBundle] Fix using the framework without the Console component| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -While working on#50787 I've noticed that it's impossible to use the framework without the Console component, event though it's an optional dependency.This PR aims to fix that. I've tested these changes on 5.4 & 6.3, however, I only made sure the container can compile. I'm not sure if there are any other gotchas.Commits-------feddf40 [DebugBundle][FrameworkBundle] Fix using the framework without the Console component
54c97a4 tof76fd88CompareMemberAuthor
HypeMC commentedJul 13, 2023
@lyrixx Done |
src/Symfony/Component/Messenger/EventListener/StopWorkerOnSignalsListener.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
f76fd88 to74b5ff1Comparenicolas-grekas added a commit that referenced this pull requestJul 19, 2023
…ypeMC)This PR was merged into the 6.4 branch.Discussion----------[Messenger] Deprecate `StopWorkerOnSignalsListener`| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | no| Deprecations? | yes| Tickets | -| License | MIT| Doc PR | -Followup to#50787.Commits-------0b62ce8 [Messenger] Deprecate `StopWorkerOnSignalsListener`
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
derrabus added a commit that referenced this pull requestJul 25, 2023
This PR was merged into the 6.4 branch.Discussion----------[FrameworkBundle] Fix using messenger 7.0| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Makes sure messenger v7.0 wouldn't break, see#51064 (comment). Could be update for#50787 (comment) as well.Commits-------9a45ae0 [FrameworkBundle] Fix using messenger 7.0
74b5ff1 to8cf7139Compare8cf7139 to5f45cefCompareMemberAuthor
HypeMC commentedSep 5, 2023
nicolas-grekas approved these changesSep 29, 2023
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGMT, just minor things on my side.
src/Symfony/Component/Messenger/Command/ConsumeMessagesCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Command/ConsumeMessagesCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Command/FailedMessagesRetryCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Command/ConsumeMessagesCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
5f45cef tocd6816bCompareMember
nicolas-grekas commentedSep 29, 2023
Thank you@HypeMC. |
Merged
fabpot added a commit that referenced this pull requestOct 16, 2023
This PR was merged into the 6.3 branch.Discussion----------[Messenger] Fix graceful exit| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#52077| License | MITMy previous PR#50787 accidentally broke the behavior of the `messenger:consume` command. It no longer waits for the handler to finish, instead it exists immediately.Commits-------b270382 [Messenger] Fix graceful exit
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#49539 introduced a bug where it's impossible to exit the
messenger:failed:retrycommand:Ctrl+Cdoesn't work because theStopWorkerOnSignalsListenerhandles the signal but doesn't actually exit the command, so the only way to currently exit the command is to kill it by force.