Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Nullable and default value arguments in RequestPayloadValueResolver#50747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@mdeboer
Copy link
Contributor

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#50690
LicenseMIT

This PR adds support to RequestPayloadValueResolver for nullable arguments and arguments with a default value set. See#50690 (comment)

Credits go to@nicolas-grekas for the implentation 👍🏻

@carsonbotcarsonbot added this to the6.3 milestoneJun 22, 2023
@mdeboermdeboer changed the titleNullable and default value arguments in RequestPayloadValueResolver[HttpKernel] Nullable and default value arguments in RequestPayloadValueResolverJun 22, 2023
@carsonbotcarsonbot changed the title[HttpKernel] Nullable and default value arguments in RequestPayloadValueResolverNullable and default value arguments in RequestPayloadValueResolverJun 22, 2023
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, thanks! Here are some CS fixes and GTM!

mdeboer reacted with hooray emoji
@mdeboer
Copy link
ContributorAuthor

Wow, just turned off my pc so figured I'd approve these changes on my phone. But apparently it creates a commit for every change, if you want I can squash them tomorrow 😂

Wasn't sure about the formatting. Not too happy with how it looked but thought that'd be something for a different PR.

Got lots of questions like why the serializer context keys are mentioned in the docblock but not used etc. But yeah, for a new PR I suppose 😅

@carsonbotcarsonbot changed the titleNullable and default value arguments in RequestPayloadValueResolver[HttpKernel] Nullable and default value arguments in RequestPayloadValueResolverJun 23, 2023
@nicolas-grekas
Copy link
Member

why the serializer context keys are mentioned in the docblock but not used etc

For BC, that's how we deal with adding new arguments without breaking anything until the next major.

mdeboer reacted with thumbs up emoji

@nicolas-grekasnicolas-grekasforce-pushed themdeboer/req-payload-resolver branch from21b25b0 to8d31ed5CompareJune 23, 2023 07:24
@nicolas-grekas
Copy link
Member

Thank you@mdeboer.

mdeboer reacted with hooray emoji

@nicolas-grekasnicolas-grekas merged commitd3ba2be intosymfony:6.3Jun 23, 2023
@mdeboermdeboer deleted the mdeboer/req-payload-resolver branchJune 23, 2023 11:03
@fabpotfabpot mentioned this pull requestJun 26, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+2 more reviewers

@alamiraultalamiraultalamirault approved these changes

@maxbeckersmaxbeckersmaxbeckers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

5 participants

@mdeboer@nicolas-grekas@alamirault@maxbeckers@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp