NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Messenger] Preserve existing Doctrine schema#50742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromnicolas-grekas:doctrine-deprec

Jun 22, 2023

Merged

[Messenger] Preserve existing Doctrine schema#50742

nicolas-grekas merged 1 commit intosymfony:5.4fromnicolas-grekas:doctrine-deprec

Jun 22, 2023

Conversation

Copy link

Member

nicolas-grekas commentedJun 22, 2023•
edited
Loading

Q	A
Branch?	5.4
Bug fix?	no (fixing a not released bug)
New feature?	no
Deprecations?	no
Tickets	Fix#50717
License	MIT
Doc PR	-

Inlining since Doctrine deprecated "toSaveSql" without providing an alternative.

Cleaning up a few unneeded calls toORMSetup::createConfiguration() also.

nicolas-grekas requested a review fromjderusse as acode owner

June 22, 2023 07:48

carsonbot added Status: Needs Review Messenger labels

Jun 22, 2023

carsonbot added this to the5.4 milestone

Jun 22, 2023

nicolas-grekas mentioned this pull request

Jun 22, 2023

[Messenger Doctrine] Fixed regression by #50524 causing data loss#50717

Closed

[Messenger] Preserve existing Doctrine schema

96c227a

nicolas-grekas force-pushed thedoctrine-deprec branch from8dd4074 to96c227aCompare

June 22, 2023 08:06

Copy link

MemberAuthor

nicolas-grekas commentedJun 22, 2023•
edited
Loading

/cc@morozov @derrabus @greg0ire doesthat sound correct to you?

Copy link

Member

derrabus commentedJun 22, 2023

IIRC, the alternative totoSaveSql is to introspect only the schema assets that you actually manage before comparing it to the target schema. The rationale is that if you introspect a database with lots of tables/columns/indexes/etc although you're interested in one table only, you keep the database unnecessarily busy.