Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Remove BC layer#50736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:7.0fromlyrixx:serializer-7
Jun 30, 2023
Merged

Conversation

@lyrixx
Copy link
Member

QA
Branch?7.0
Bug fix?no
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

dunglas and tucksaun reacted with thumbs up emoji
Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for working on this!

Blocking as the necessary CHANGELOG and UPGRADE guide changes are missing ;)

@lyrixx
Copy link
MemberAuthor

Blocking as the necessary CHANGELOG and UPGRADE guide changes are missing ;)

Yeah 👍🏼 But I don't remember what are the new guidelines for 7.0. Is there a summary of what I must do for each files?

@tucksaun
Copy link
Contributor

It was on my todo list for the summer, thank you for taking care of it 😌

lyrixx reacted with heart emoji

@GromNaN
Copy link
Member

Is there a summary of what I must do for each files?

UPGRADE-7.0.md needs to be updated on the branch 7.0 for each deprecated feature that is removed. Asyou tried before.

@nicolas-grekas
Copy link
Member

See fabbot also (except the false-positive on the switch)

@lyrixxlyrixx mentioned this pull requestJun 27, 2023
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add lines to the changelog of the component, same to the root UPGRADE-7.0.md file, and possibly ake the title of this PR more useful for a changelog

@lyrixx
Copy link
MemberAuthor

I don't know how to fix theses tests inhttps://github.com/symfony/symfony/actions/runs/5406243227/jobs/9822895029?pr=50736#step:8:9587

1) Symfony\Component\Messenger\Tests\Stamp\ErrorDetailsStampTest::testDeserializationError: Interface "Symfony\Component\Serializer\Normalizer\ContextAwareNormalizerInterface" not found/home/runner/work/symfony/symfony/src/Symfony/Component/Messenger/Transport/Serialization/Normalizer/FlattenExceptionNormalizer.php:25/home/runner/work/symfony/symfony/src/Symfony/Component/Messenger/vendor/symfony/error-handler/DebugClassLoader.php:296/home/runner/work/symfony/symfony/src/Symfony/Component/Messenger/Tests/Stamp/ErrorDetailsStampTest.php:62

@nicolas-grekas
Copy link
Member

fix theses tests

Can we stop usingContextAwareNormalizerInterface in Messenger on branch 6.4? If not, we'll have to declare on branch 6.4 that Messenger 6.4 doesn't work with serializer ^7

@lyrixx
Copy link
MemberAuthor

lyrixx commentedJun 29, 2023•
edited
Loading

I checked, and We don't allow 7 in lower branches
https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/ErrorHandler/composer.json#L25

Can we stop usingContextAwareNormalizerInterface in Messenger on branch 6.4?

I can check

@derrabus
Copy link
Member

Can we stop usingContextAwareNormalizerInterface in Messenger on branch 6.4?

We probably can by dropping support for Serializer 5 which would be acceptable imho.

@lyrixx
Copy link
MemberAuthor

Can we stop usingContextAwareNormalizerInterface in Messenger on branch 6.4

Done ➡#50824

nicolas-grekas added a commit that referenced this pull requestJun 30, 2023
…e anymore (lyrixx)This PR was merged into the 6.4 branch.Discussion----------[ErrorHandler] Do not use ContextAwareNormalizerInterface anymore| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |It's a deprecated feature +#50736Commits-------133171b [ErrorHandler] Do not use ContextAwareNormalizerInterface anymore
@nicolas-grekas
Copy link
Member

Thank you@lyrixx.

@nicolas-grekasnicolas-grekas merged commit0132503 intosymfony:7.0Jun 30, 2023
@lyrixxlyrixx deleted the serializer-7 branchJune 30, 2023 10:21
@fabpotfabpot mentioned this pull requestOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjwouterj requested changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

7 participants

@lyrixx@tucksaun@GromNaN@nicolas-grekas@derrabus@wouterj@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp