Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[CssSelector] Tests on Xpath translator will always pass#50729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromfranckranaivo:fix-test-xpath-translatorJul 7, 2023
Merged
[CssSelector] Tests on Xpath translator will always pass#50729
nicolas-grekas merged 1 commit intosymfony:5.4fromfranckranaivo:fix-test-xpath-translatorJul 7, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
And the test now fails 😅 |
Fixed the failing tests. Xpath translator in itself is not to blame, it is just some wrong assertion or misunderstanding of rules of the selector for some tests. |
5e2d5d1 tobb123abCompareGood catch, thanks@franckranaivo. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on another PR (#49388), I noticed that the assertion below will always pass as it is testing the count of the same array on both side.
Instead of
$this->assertCount(\count($elementsId), $elementsId);It should be
$this->assertCount(\count($elementsId), $elements);This PR should fix also numbers and/or Xpath translator issues from this fixed assertion.
P.S.
This is the right PR for this issue (#50726)