Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger Doctrine] Fixed regression by #50524 causing data loss#50717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
brusch wants to merge1 commit intosymfony:5.4frombrusch:patch-2
Closed

Conversation

@brusch
Copy link
Contributor

@bruschbrusch commentedJun 20, 2023•
edited
Loading

Regression caused by#50524

When using$platform->getAlterSchemaSQL($schemaDiff) instead of$schemaDiff->toSaveSql($platform) causes to call\Doctrine\DBAL\Schema\SchemaDiff::_toSql($platform, false) instead of\Doctrine\DBAL\Schema\SchemaDiff::_toSql($platform, true). When $saveMode=false the diff from the schema is getting remove, so actually all other tables ... in the DB are getting deleted

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no >
LicenseMIT

Follow up to#50716 which was closed automatically by mistake 😊

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "5.4" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@brusch
Copy link
ContributorAuthor

Ok, according todoctrine/dbal#5766 there's no replacement forSchemaDiff::toSaveSql().
But still, in Symfony we can't change togetAlterSchemaSQL() in a minor version as it would be a breaking change.

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedJun 22, 2023•
edited
Loading

Replaced by#50742, thanks for raising this.

nicolas-grekas added a commit that referenced this pull requestJun 22, 2023
…rekas)This PR was merged into the 5.4 branch.Discussion----------[Messenger] Preserve existing Doctrine schema| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no (fixing a not released bug)| New feature?  | no| Deprecations? | no| Tickets       |Fix#50717| License       | MIT| Doc PR        | -[Inlining](https://github.com/symfony/symfony/pull/50742/files#diff-2a38c9deb498eec50126c297bb3d094c8efb29364934e902d6481761ace6f20a) since Doctrine deprecated "toSaveSql" without providing an alternative.Cleaning up a few unneeded calls to `ORMSetup::createConfiguration()` also.Commits-------96c227a [Messenger] Preserve existing Doctrine schema
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@brusch@carsonbot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp