Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] Fix encoding some characters in query strings#50671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Kozzi11
Copy link

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#50670
LicenseMIT
Doc PRsymfony/symfony-docs#...

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@Kozzi11Kozzi11force-pushed thehttp_client_parse_rfc_compliant branch frome35e256 toffc94baCompareJune 15, 2023 13:04
@OskarStarkOskarStark changed the title[HttpClient] Fix #50670 - Make HttpClient parseUrl RFC compliant[HttpClient] Make HttpClient parseUrl RFC compliantJun 19, 2023
@nicolas-grekasnicolas-grekas changed the title[HttpClient] Make HttpClient parseUrl RFC compliant[HttpClient] Fix encoding some characters in query stringsJun 20, 2023
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unfortunately, the RFC is very loose on the topic, and implementations varies.

@nicolas-grekasnicolas-grekasforce-pushed thehttp_client_parse_rfc_compliant branch fromac3f01b tocb26c19CompareJune 21, 2023 09:50
@nicolas-grekas
Copy link
Member

Thank you@Kozzi11.

Kozzi11 reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof requested changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@Kozzi11@carsonbot@nicolas-grekas@stof
[8]ページ先頭
©2009-2025 Movatter.jp