Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Ignore missing directories in about command#50665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromro0NL:patch-1
Jun 21, 2023
Merged

[FrameworkBundle] Ignore missing directories in about command#50665

fabpot merged 1 commit intosymfony:5.4fromro0NL:patch-1
Jun 21, 2023

Conversation

@ro0NL
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes IMHO
New feature?no
Deprecations?no
TicketsFix #...
LicenseMIT
Doc PRsymfony/symfony-docs#...

This fixes our CI whenvar/log is missing.

Before:

In AboutCommand.php line 105:                                                                                                                [UnexpectedValueException]                                                                                    RecursiveDirectoryIterator::__construct(/app/var/log): Failed to open directory: No such file or directory

After:

  Cache directory      ./var/cache/prod (939 KiB)    Build directory      ./var/cache/prod (939 KiB)    Log directory        ./var/log (n/a)

$size =filesize($path) ?:0;
}else {
if (!is_dir($path)) {
return'n/a';
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the abstraction for "formatted file size" is any string, hence this looks appropriate to me

@fabpot
Copy link
Member

Thank you@ro0NL.

@fabpotfabpot merged commit5c512f6 intosymfony:5.4Jun 21, 2023
@ro0NLro0NL deleted the patch-1 branchJune 21, 2023 06:30
This was referencedJun 26, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@ro0NL@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp