Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Make some classes final#50660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Make some classes final#50660
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
lyrixx commentedJun 14, 2023
| Q | A |
|---|---|
| Branch? | 7.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
Uh oh!
There was an error while loading.Please reload this page.
lyrixx commentedJun 14, 2023
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/ErrorHandler/Tests/DebugClassLoaderTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
derrabus added a commit that referenced this pull requestJun 22, 2023
…zer (lyrixx)This PR was merged into the 6.3 branch.Discussion----------[Serializer] Refactor tests to not extends ObjectNormalizer| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |see#50660 (comment)Commits-------2269c3f [Serializer] Refactor tests to not extends ObjectNormalizer
Member
nicolas-grekas commentedJun 27, 2023
(rebase needed) |
MemberAuthor
lyrixx commentedJun 27, 2023
I need to finish#50736 first |
Member
nicolas-grekas commentedJun 30, 2023
Thank you@lyrixx. |
nicolas-grekas added a commit that referenced this pull requestJun 30, 2023
This PR was merged into the 7.0 branch.Discussion----------Make some classes final| Q | A| ------------- | ---| Branch? | 7.0| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |Commits-------f39ede4 Make some classes final
MemberAuthor
lyrixx commentedJun 30, 2023
This is weird, the PR has not been closed?! |
Member
nicolas-grekas commentedJun 30, 2023
🤷 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.