Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Fixed parsing new JSON output of debug:config not possible#50637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Toflar
Copy link
Contributor

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

See my comment to the original PR which introduceddebug:config --format=json:#48457 (comment)

Currently, it's not possible to parse the JSON output (neither is the YAML) which makes--format=json kind of pointless. The argument against this - I guess - is that the JSON format was introduced to make the command independent from the YAML component but still, why is--format an option then?

So I guess by delivering an additional option, we can fix this issue and make it parsable.

(Maybe instead of having--no-tilte we should call itparsable in the first place so that if in the future there's something on top of the title, the option would still be valid?)

@stof
Copy link
Member

The title should be only for the text format IMO

@Toflar
Copy link
ContributorAuthor

There is no text format. The default isyaml and it hasn't been parsable ever since. Now in 6.3, there's a new fallback tojson in case the Yaml component is not installed. But there is also a new--format option.

@stof
Copy link
Member

then maybe the title should be removed or be an info written to stderr instead of stdout

@Toflar
Copy link
ContributorAuthor

I don't really see any value in the title either but I don't feel like I'm in charge to decide on this 😄

@ro0NL
Copy link
Contributor

maybe show title if --format is not given

or put different, the default format can be newtext which shows title+yaml, but --format=yaml shows no title

@Toflar
Copy link
ContributorAuthor

I like that suggestions so I've quickly implemented a first version - wdyt?

@carsonbotcarsonbot changed the titleFixed parsing new JSON output of debug:config not possible[FrameworkBundle] Fixed parsing new JSON output of debug:config not possibleJun 21, 2023
@fabpotfabpotforce-pushed thefix/broken-json-output-in-config-command branch from26ebc65 toa3e8560CompareJune 24, 2023 09:59
@fabpot
Copy link
Member

Thank you@Toflar.

@fabpotfabpot merged commit1cbfc29 intosymfony:6.3Jun 24, 2023
@fabpotfabpot mentioned this pull requestJun 26, 2023
@ToflarToflar deleted the fix/broken-json-output-in-config-command branchOctober 2, 2023 07:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

6 participants

@Toflar@stof@ro0NL@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp