Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][Workflow] Add metadata dumping support forGraphvizDumper#50621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedJun 9, 2023
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
3e8f6a7 to47757b7Compare5ff2322 tocad1bd5Compare
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I rebased + fixed a few things.
GraphvizDumperUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| } | ||
| /** | ||
| * @internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why make this internal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
because all methods are in this class
nicolas-grekas commentedJun 21, 2023
Thank you@Louis-Proffit. |
| 'graph' => [ | ||
| 'label' =>$input->getOption('label'), | ||
| ], | ||
| 'label' =>$input->getOption('label'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Isn't this a BC break if someone uses the dumper in their own code (as they would have to change the options being passed to thedump() method)?
Uh oh!
There was an error while loading.Please reload this page.
Add
--with-metadataoption toworkflow:dumpcommand. It includes places, transitions and workflow's metadata in the dumped graph. Currently only supported forGraphvizDumper andStateMachineGraphvizDumper.When used, the
labelmetadata is not included in the dumped metadata because it is already the title. This could be enlarged to all styling metadata.