Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Fix RedisTrait::createConnection for cluster#50585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@darkanakin41
Copy link
Contributor

@darkanakin41darkanakin41 commentedJun 7, 2023•
edited by nicolas-grekas
Loading

QA
Branch?5.4
Bug fix?yes
New feature?No
Deprecations?No
TicketsFix#50509
LicenseMIT
Doc PRN/A

When the dsn containsredis_cluster=1 orredis_cluster=true the value was not properly parsed, and the class generated was not the expected RedisCluster.

The reason is that the PHP core functionmatch make a=== check.

So, as the dsn is a string, the$params['redis_cluster'] needs to be force to a bool

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the titlebug #50509 [Cache] Fix RedisTrait::createConnection for cluster[Cache] bug #50509 Fix RedisTrait::createConnection for clusterJun 7, 2023
@darkanakin41
Copy link
ContributorAuthor

darkanakin41 commentedJun 7, 2023•
edited
Loading

I don't know how to fix appveyor :(

@derrabus
Copy link
Member

I don't know how to fix appveyor :(

You don't need to. The failure is unrelated to your changes.

darkanakin41 reacted with hooray emoji

@nicolas-grekasnicolas-grekas changed the title[Cache] bug #50509 Fix RedisTrait::createConnection for cluster[Cache] Fix RedisTrait::createConnection for clusterJun 8, 2023
@nicolas-grekasnicolas-grekas modified the milestones:6.3,5.4Jun 8, 2023
@nicolas-grekasnicolas-grekas changed the base branch from6.3 to5.4June 8, 2023 21:03
@nicolas-grekasnicolas-grekasforce-pushed theissue-50509-redis-trait-dsn-processing branch from5c59e89 toca8e328CompareJune 8, 2023 21:04
@nicolas-grekas
Copy link
Member

Thank you@darkanakin41.

darkanakin41 reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commitca9a8c1 intosymfony:5.4Jun 8, 2023
This was referencedJun 26, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@wouterjwouterjAwaiting requested review from wouterj

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@darkanakin41@carsonbot@derrabus@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp