Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DependencyInjection] Remove deprecations across the component#50578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-dauboisalexandre-daubois commentedJun 6, 2023
edited by nicolas-grekas
Loading

QA
Branch?7.0
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT
Doc PR-
  • Remove#[MapDecorated], use#[AutowireDecorated] instead
  • RemoveProxyHelper, useSymfony\Component\VarExporter\ProxyHelper instead
  • RemoveReferenceSetArgumentTrait
  • Remove support of@required annotation, use theSymfony\Contracts\Service\Attribute\Required attribute instead
  • Passingnull toContainerAwareTrait::setContainer() must be done explicitly
  • RemovePhpDumper optionsinline_factories_parameter andinline_class_loader_parameter, use optionsinline_factories andinline_class_loader instead
  • Parameter names ofParameterBag cannot be numerics
  • RemoveContainerAwareInterface andContainerAwareTrait, use dependency injection instead
  • RemoveContainerAwareLoader, use dependency injection in your fixtures instead

@alexandre-dauboisalexandre-dauboisforce-pushed thedi-deprecations branch 2 times, most recently from9a62ed7 to0757d42CompareJune 9, 2023 12:02
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

WitherAnnotationStaticReturnType, etc, there are still many fixtures that should be removed.
Using grep for "deprecated" in the component might help. Careful self-review also.
Thanks! 🙏

alexandre-daubois reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

(failures are related)

@alexandre-daubois
Copy link
MemberAuthor

I'll have a look at them, thank you for investigating Nicolas!

nicolas-grekas added a commit that referenced this pull requestJun 20, 2023
…ce`, `ContainerAwareTrait` and `ContainerAwareLoader` (alexandre-daubois)This PR was merged into the 6.4 branch.Discussion----------[DependencyInjection] Deprecate `ContainerAwareInterface`, `ContainerAwareTrait` and `ContainerAwareLoader`| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | yes| Tickets       | -| License       | MIT| Doc PR        | -As discussed in#50578 (comment)Commits-------fc3c572 [DependencyInjection] Deprecate `ContainerAwareInterface`, `ContainerAwareTrait` and `ContainerAwareLoader`
@alexandre-daubois
Copy link
MemberAuthor

alexandre-daubois commentedJun 21, 2023
edited
Loading

I'm currently having a look at the failing jobhttps://github.com/symfony/symfony/actions/runs/5335835620/jobs/9669640171?pr=50578

@alexandre-dauboisalexandre-dauboisforce-pushed thedi-deprecations branch 2 times, most recently from4a863f8 toe3d816eCompareJune 21, 2023 15:26
@alexandre-dauboisalexandre-dauboisforce-pushed thedi-deprecations branch 2 times, most recently from32cb2fc to0b9660fCompareJune 22, 2023 08:34
@nicolas-grekasnicolas-grekasforce-pushed thedi-deprecations branch 2 times, most recently fromcd33c9b tocb0e036CompareJune 30, 2023 13:14
@alexandre-dauboisalexandre-dauboisforce-pushed thedi-deprecations branch 4 times, most recently from6eda6bf to60cdce8CompareJune 30, 2023 15:11
nicolas-grekas added a commit that referenced this pull requestJun 30, 2023
…(nicolas-grekas)This PR was merged into the 6.4 branch.Discussion----------[HttpKernel] Do not use ContainerAwareInterface anymore| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Similar to#50824, keeping this interface blocks compat of HK v6 with DI v7 for no good reasons. Let's drop ContainerAwareInterface from BundleInterface, it serves no purpose anyway.Unlocks#50578Commits-------640c72a [HttpKernel] Do not use ContainerAwareInterface anymore
@nicolas-grekas
Copy link
Member

Thank you@alexandre-daubois.

@nicolas-grekasnicolas-grekas merged commit0fdf5eb intosymfony:7.0Jun 30, 2023
@alexandre-dauboisalexandre-daubois deleted the di-deprecations branchJune 30, 2023 16:03
@fabpotfabpot mentioned this pull requestOct 21, 2023
nicolas-grekas added a commit that referenced this pull requestJun 6, 2025
…handling (MatTheCat)This PR was merged into the 7.2 branch.Discussion----------[DependencyInjection] Fix `ServiceLocatorTagPass` indexes handling| Q             | A| ------------- | ---| Branch?       | 7.2| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        |Fix#60651| License       | MIT#50578 changed the `ServiceLocatorTagPass`’ behavior so that if the map is a list, its indexes always are replaced by the corresponding reference ID, even if they come from the `PriorityTaggedServiceTrait`. That means if your service map ends up as a list because e.g. your `default_index_method` returned contiguous integer, its indexes will be replaced.This PR reverts this change so that it works the same than v6.Commits-------a73c9d1 [DependencyInjection] Fix `ServiceLocatorTagPass` indexes handling
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@wouterjwouterjwouterj left review comments

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@alexandre-daubois@nicolas-grekas@wouterj@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp