Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DoctrineBridge] Remove deprecated classes andContainerAwareEventManager::getListeners() deprecation#50575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alexandre-daubois
Copy link
Member

QA
Branch?7.0
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Removes deprecated code introduced in#49610

@alexandre-dauboisalexandre-dauboisforce-pushed thedoctrine-bridge-classes-deprecations branch fromdb7df29 to9c44816CompareJune 7, 2023 12:32
@alexandre-dauboisalexandre-dauboisforce-pushed thedoctrine-bridge-classes-deprecations branch from9c44816 toa97b1f2CompareJune 7, 2023 12:38
@alexandre-dauboisalexandre-dauboisforce-pushed thedoctrine-bridge-classes-deprecations branch 2 times, most recently from1de5b05 to947912bCompareJune 7, 2023 13:32
@alexandre-dauboisalexandre-dauboisforce-pushed thedoctrine-bridge-classes-deprecations branch from9ce38fe to3c9c2b7CompareJune 8, 2023 12:23
@derrabusderrabus requested a review fromstofJune 8, 2023 12:27
nicolas-grekas added a commit that referenced this pull requestJun 8, 2023
…eEventManager` (alexandre-daubois)This PR was merged into the 6.3 branch.Discussion----------[DoctrineBridge] Remove (wrong) PHPDoc on `ContainerAwareEventManager`| Q             | A| ------------- | ---| Branch?       | 6.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -This PR is a follow-up of the following discussion:#50575 (comment)Commits-------d65db40 [DoctrineBridge] Remove (wrong) PHPDoc on `ContainerAwareEventManager`
symfony-splitter pushed a commit to symfony/doctrine-bridge that referenced this pull requestJun 8, 2023
…eEventManager` (alexandre-daubois)This PR was merged into the 6.3 branch.Discussion----------[DoctrineBridge] Remove (wrong) PHPDoc on `ContainerAwareEventManager`| Q             | A| ------------- | ---| Branch?       | 6.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -This PR is a follow-up of the following discussion:symfony/symfony#50575 (comment)Commits-------d65db4073b [DoctrineBridge] Remove (wrong) PHPDoc on `ContainerAwareEventManager`
@nicolas-grekas
Copy link
Member

(rebase needed)

@alexandre-dauboisalexandre-dauboisforce-pushed thedoctrine-bridge-classes-deprecations branch from3c9c2b7 toc839f87CompareJune 9, 2023 07:17
@alexandre-daubois
Copy link
MemberAuthor

Rebased and updated withDbalLogger (and other) deprecations introduced in 6.4

@alexandre-dauboisalexandre-dauboisforce-pushed thedoctrine-bridge-classes-deprecations branch fromc839f87 to4f3337dCompareJune 9, 2023 07:20
@derrabus
Copy link
Member

derrabus commentedJun 9, 2023•
edited
Loading

FYI: DbalLogger is removed by#50571 already. But I'm fine either way, let's keep the change here and finish your PR first.

@derrabus
Copy link
Member

You need to adjust the expected-missing-return-types.diff file. You can borrow the necessary change from#50571.

alexandre-daubois reacted with heart emoji

@derrabusderrabus mentioned this pull requestJun 9, 2023
5 tasks
@nicolas-grekasnicolas-grekasforce-pushed thedoctrine-bridge-classes-deprecations branch from4f3337d to929e64dCompareJune 9, 2023 08:59
@nicolas-grekasnicolas-grekasforce-pushed thedoctrine-bridge-classes-deprecations branch from929e64d to746b123CompareJune 9, 2023 09:01
@nicolas-grekas
Copy link
Member

Thank you@alexandre-daubois.

@stof
Copy link
Member

stof commentedJun 9, 2023

@derrabus to avoid having to regenerate the expected-missing-return-types.diff file all the time in those code removal PRs, maybe we should first add those return types in 7.0 (by applying the patch defined in this diff file)

@derrabus
Copy link
Member

That's probably a good idea.

fabpot added a commit that referenced this pull requestJun 9, 2023
This PR was merged into the 7.0 branch.Discussion----------[DoctrineBridge] Kill DBAL 2 support| Q             | A| ------------- | ---| Branch?       | 7.0| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | N/A| License       | MIT| Doc PR        | N/ADBAL 2 is dead and buried. Let's remove code that we needed to maintain DBAL 2.TODO:- [x] Deprecation layer for removed classes- [x] Check changes for possible backports to 5.4/6.4- [x]#50576- [x]#50579- [x]#50575Commits-------eacfedf Kill DBAL 2 support
nicolas-grekas added a commit that referenced this pull requestJun 30, 2023
…here it is not used (GromNaN)This PR was merged into the 7.0 branch.Discussion----------[Doctrine][Serializer] Remove `ExpectDeprecationTrait` where it is not used| Q             | A| ------------- | ---| Branch?       | 7.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | n/aThis unused code has been left by#50558 and#50575.I think PHPStan should detect when the trait is imported but the method `expectDeprecation` is not used.Other PR for 6.4#50828Commits-------81972d3 Remove ExpectDeprecationTrait where it is not used
@fabpotfabpot mentioned this pull requestOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus approved these changes

@stofstofAwaiting requested review from stof

Assignees

No one assigned

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@alexandre-daubois@nicolas-grekas@derrabus@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp