Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DoctrineBridge] Kill DBAL 2 support#50571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.0fromderrabus:remove/dbal-2
Jun 9, 2023

Conversation

@derrabus
Copy link
Member

@derrabusderrabus commentedJun 6, 2023•
edited by nicolas-grekas
Loading

QA
Branch?7.0
Bug fix?no
New feature?yes
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

DBAL 2 is dead and buried. Let's remove code that we needed to maintain DBAL 2.

TODO:

dmaicher, greg0ire, and andreybolonin reacted with thumbs up emoji
@carsonbotcarsonbot added this to the7.0 milestoneJun 6, 2023
@carsonbotcarsonbot changed the titleKill DBAL 2 support[Doctrine] Kill DBAL 2 supportJun 6, 2023
@derrabusderrabusforce-pushed theremove/dbal-2 branch 2 times, most recently fromeaa0c92 tof174043CompareJune 6, 2023 11:11
@nicolas-grekas
Copy link
Member

Can't we target 6.4? That'd be nicer to the community.

@derrabus
Copy link
MemberAuthor

Can't we target 6.4?

You mean drop DBAL 2 in 6.4 already? We can, but I didn't want to cut off projects that still run on DBAL 2 (or at least support it) on a minor release. I cannot really tell what the impact of that change would be.

That'd be nicer to the community.

One could argue that giving the community an LTS for migrating away from a still very popular package would be nicer though.

@stof
Copy link
Member

stof commentedJun 6, 2023

Well, older versions of DoctrineBundle don't work well with Symfony 6.3 anyway (for instance, theMapEntity attribute would break) and DoctrineBundle 2.9+ already requires DBAL 3.6+.
So I would say that if you are still using DBAL 2, you are almost required to stick to Symfony 5.4 currently.

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedJun 6, 2023•
edited
Loading

You mean drop DBAL 2 in 6.4 already?

Yes!
Major versions should be as boring as possibly doable, and that includes not doing version bumps if possible. Minor versions are better candidates for those bumps.

derrabus added a commit that referenced this pull requestJun 8, 2023
…latform` (derrabus)This PR was merged into the 5.4 branch.Discussion----------[DoctrineBridge][Messenger] Add test cases for `MariaDBPlatform`| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | Backport from#50571| License       | MIT| Doc PR        | N/AThis PR adds test cases specifically for DBAL's `MariaDBPlatform` class. DBAL 4 will change the inheritance hierarchy for MySQL-like platforms, so having those tests might safe us one fine day.Commits-------618de82 Add test cases for MariaDBPlatform
@derrabusderrabusforce-pushed theremove/dbal-2 branch 2 times, most recently from9eff782 to7ed12d3CompareJune 8, 2023 12:48
@derrabusderrabus requested a review fromdunglas as acode ownerJune 8, 2023 12:48
@derrabus
Copy link
MemberAuthor

Minor versions are better candidates for those bumps.

In our case, it leaves DBAL 2 projects pinned to a non-LTS Symfony branch. But well,they have been warned, right?

I can work out a PR for 6.4 once#50576 and#50579 are done. We can continue the discussion there.

nicolas-grekas added a commit that referenced this pull requestJun 8, 2023
…ystem (derrabus)This PR was merged into the 6.4 branch.Discussion----------[DoctrineBridge] Deprecate using the old DBAL logger system| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | yes| Tickets       | Backport from#50571| License       | MIT| Doc PR        | N/ACommits-------a8f6243 Deprecate using the old DBAL logger system
nicolas-grekas added a commit that referenced this pull requestJun 8, 2023
This PR was merged into the 6.4 branch.Discussion----------[DoctrineBridge] Require ORM 2.15| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | Backported from#50571| License       | MIT| Doc PR        | N/ACommits-------37e9d60 Require ORM 2.15
@nicolas-grekas
Copy link
Member

I'm torn now. I'd fine either way, which means fine for 7.0 :)

derrabus reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas changed the title[Doctrine] Kill DBAL 2 support[DoctrineBridge] Kill DBAL 2 supportJun 8, 2023
@fabpot
Copy link
Member

Thank you@derrabus.

@fabpotfabpot merged commitd63071c intosymfony:7.0Jun 9, 2023
@derrabusderrabus deleted the remove/dbal-2 branchJune 9, 2023 14:03
@fabpotfabpot mentioned this pull requestOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@chalasrchalasrchalasr left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@wouterjwouterjAwaiting requested review from wouterj

@jderussejderusseAwaiting requested review from jderussejderusse is a code owner

@dunglasdunglasAwaiting requested review from dunglas

Assignees

No one assigned

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

6 participants

@derrabus@nicolas-grekas@stof@fabpot@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp