NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[FrameworkBundle] Show non-bundle extensions in`debug:config` &`config:dump` list view & completion#50548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromHypeMC:kernel-extensions

Jun 8, 2023

Merged

[FrameworkBundle] Show non-bundle extensions in`debug:config` &`config:dump` list view & completion#50548

nicolas-grekas merged 1 commit intosymfony:5.4fromHypeMC:kernel-extensions

Jun 8, 2023

Conversation

Copy link

Member

HypeMC commentedJun 4, 2023•
edited
Loading

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

Follow up to#50546 (should be merged first), adds non-bundle extensions todebug:config &config:dump list views:

class Kernelextends BaseKernelimplements ExtensionInterface, ConfigurationInterface{use MicroKernelTrait;protectedfunctionbuild(ContainerBuilder$container)    {$container->registerExtension(newMyExtension());    }publicfunctiongetAlias()    {return'kernel';    }// ...}

carsonbot added Status: Needs Review Feature FrameworkBundle labels

Jun 4, 2023

carsonbot added this to the6.4 milestone

Jun 4, 2023

HypeMC mentioned this pull request

Jun 4, 2023

[FrameworkBundle] Fixdebug:config &config:dump in debug mode#50546

Merged

chalasr approved these changes

Jun 4, 2023

View reviewed changes

Copy link

Member

chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch. I'd call that a bugfix

src/Symfony/Bundle/FrameworkBundle/Command/AbstractConfigCommand.php OutdatedShow resolvedHide resolved

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jun 4, 2023

HypeMC force-pushed thekernel-extensions branch frombfe288e to58ebfecCompare

June 4, 2023 15:53

Copy link

MemberAuthor

HypeMC commentedJun 4, 2023

Good catch. I'd call that a bugfix

Works for me, if needed I'll rebase this with 5.4 once#50546 is merged.

nicolas-grekas added a commit that referenced this pull request

Jun 8, 2023

bug#50546[FrameworkBundle] Fixdebug:config&config:dumpin de…

dda4e7c

…bug mode (HypeMC)This PR was merged into the 5.4 branch.Discussion----------[FrameworkBundle] Fix `debug:config` & `config:dump` in debug mode| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#47623| License       | MIT| Doc PR        | -Displaying configs for extensions without a bundle using the `debug:config` & `config:dump-reference` commands works depending on whether debug is `true` or `false`. The reason behind this is the following code:https://github.com/symfony/symfony/blob/b4128fdefea4ff95b27861bf65ba789d24868df1/src/Symfony/Bundle/FrameworkBundle/Command/BuildDebugContainerTrait.php#L42-L60When debug is `true` the extensions are never loaded in the container, so the commands don't work.There are even tests for these cases but they are all executed with debug `false`.This PR aims to make the commands work with both debug `true` & `false`. Another problem is that these extensions are not visible in the list of available extensions and are not offered by the completion feature, but since those seem more like new features I've created a separate PR for 6.4:#50548Commits-------2824fc5 [FrameworkBundle] Fix `debug:config` & `config:dump` in debug mode