Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Fixdebug:config &config:dump in debug mode#50546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromHypeMC:kernel-extensions-5.4
Jun 8, 2023

Conversation

@HypeMC
Copy link
Member

@HypeMCHypeMC commentedJun 4, 2023•
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#47623
LicenseMIT
Doc PR-

Displaying configs for extensions without a bundle using thedebug:config &config:dump-reference commands works depending on whether debug istrue orfalse. The reason behind this is the following code:

if (!$kernel->isDebug() || !(newConfigCache($kernel->getContainer()->getParameter('debug.container.dump'),true))->isFresh()) {
$buildContainer = \Closure::bind(function () {
$this->initializeBundles();
return$this->buildContainer();
},$kernel,\get_class($kernel));
$container =$buildContainer();
$container->getCompilerPassConfig()->setRemovingPasses([]);
$container->getCompilerPassConfig()->setAfterRemovingPasses([]);
$container->compile();
}else {
(newXmlFileLoader($container =newContainerBuilder(),newFileLocator()))->load($kernel->getContainer()->getParameter('debug.container.dump'));
$locatorPass =newServiceLocatorTagPass();
$locatorPass->process($container);
$container->getCompilerPassConfig()->setBeforeOptimizationPasses([]);
$container->getCompilerPassConfig()->setOptimizationPasses([]);
$container->getCompilerPassConfig()->setBeforeRemovingPasses([]);
}

When debug istrue the extensions are never loaded in the container, so the commands don't work.

There are even tests for these cases but they are all executed with debugfalse.

This PR aims to make the commands work with both debugtrue &false. Another problem is that these extensions are not visible in the list of available extensions and are not offered by the completion feature, but since those seem more like new features I've created a separate PR for 6.4:#50548

@HypeMCHypeMCforce-pushed thekernel-extensions-5.4 branch from73871a7 to2824fc5CompareJune 6, 2023 10:43
@nicolas-grekas
Copy link
Member

Thank you@HypeMC.

@nicolas-grekasnicolas-grekas merged commitdda4e7c intosymfony:5.4Jun 8, 2023
@HypeMCHypeMC deleted the kernel-extensions-5.4 branchJune 8, 2023 19:22
nicolas-grekas added a commit that referenced this pull requestJun 8, 2023
…fig` & `config:dump` list view & completion (HypeMC)This PR was merged into the 5.4 branch.Discussion----------[FrameworkBundle] Show non-bundle extensions in `debug:config` & `config:dump` list view & completion| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Follow up to#50546 (should be merged first), adds non-bundle extensions to `debug:config` & `config:dump` list views:```phpclass Kernel extends BaseKernel implements ExtensionInterface, ConfigurationInterface{    use MicroKernelTrait;    protected function build(ContainerBuilder $container)    {        $container->registerExtension(new MyExtension());    }    public function getAlias()    {        return 'kernel';    }    // ...}```![image](https://github.com/symfony/symfony/assets/2445045/5c75d33a-155c-4602-abf8-8babc72286b6)Commits-------b31f700 [FrameworkBundle] Show non-bundle extensions in `debug:config` & `config:dump` list view & completion
This was referencedJun 26, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@HypeMC@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp