Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] Add placeholders to ProgressBar for exact times#50537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@maxbeckers
Copy link
Contributor

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#49927
LicenseMIT
Doc PRsymfony/symfony-docs#... TBD

This is an idea for exact times using ProgressBar based on the idea of@GromNaN in the issue#49927.

Open to discuss this first way of implementing it.

I'll create the docs PR when the feature is agreed and there won't come up any bigger changes.

The Idea is to show the exact time in seconds, the ProgressBar will run / is running.

@carsonbotcarsonbot added this to the6.4 milestoneJun 2, 2023
@maxbeckersmaxbeckersforce-pushed thepatch_49927_console_remaining_time branch 3 times, most recently from1eecd3b to82a1c62CompareJune 5, 2023 05:09
@wouterj
Copy link
Member

I think we can simplify this to just replace the existingelapsed parameter with the new format. We do not promise backwards compatible CLI output, and I would argue that interactive elements like the progress bar should never be interpreted by any program anyways.

GromNaN and OskarStark reacted with thumbs up emoji

@maxbeckersmaxbeckersforce-pushed thepatch_49927_console_remaining_time branch from82a1c62 toc0ca8f9CompareOctober 9, 2023 09:02
@maxbeckers
Copy link
ContributorAuthor

Thanks@wouterj and@OskarStark for your input. I now changed it.

OskarStark reacted with thumbs up emoji

@OskarStarkOskarStark added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelOct 9, 2023
Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me!

@maxbeckersmaxbeckersforce-pushed thepatch_49927_console_remaining_time branch fromc0ca8f9 to190f835CompareOctober 9, 2023 09:51
@maxbeckersmaxbeckersforce-pushed thepatch_49927_console_remaining_time branch from190f835 tob553dd9CompareOctober 9, 2023 11:19
@OskarStarkOskarStark changed the title[Console] Add Placeholders to ProgressBar for exactly times[Console] Add placeholders to ProgressBar for exact timesOct 9, 2023
@fabpot
Copy link
Member

Thank you@maxbeckers.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@GromNaNGromNaNGromNaN approved these changes

@wouterjwouterjwouterj approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Labels

ConsoleFeature❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: Reviewed

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

[Console] Improve the helpfulness of %remaining% in Progress Bar

6 participants

@maxbeckers@wouterj@fabpot@GromNaN@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp