NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Messenger] Prevent`StopWorkerOnSignalsListener::$signals` to be assigned to null in case`SIGTERM` constant doesn't exist#50532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.3fromalexandre-daubois:fix-null-signals

Jun 2, 2023

Merged

[Messenger] Prevent`StopWorkerOnSignalsListener::$signals` to be assigned to null in case`SIGTERM` constant doesn't exist#50532

fabpot merged 1 commit intosymfony:6.3fromalexandre-daubois:fix-null-signals

Jun 2, 2023

Conversation

Copy link

Member

alexandre-daubois commentedJun 1, 2023

Q	A
Branch?	6.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#50529
License	MIT
Doc PR	NA

Prevents the non-nullable property to be assigned to null 🙂

[Messenger] PreventStopWorkerOnSignalsListener::$signals to be ass…

538a9ab

…igned to null in case `SIGTERM` constant doesn't exist

carsonbot added Status: Needs Review Bug Messenger labels

Jun 1, 2023

carsonbot added this to the6.4 milestone

Jun 1, 2023

Copy link

carsonbot commentedJun 1, 2023

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

alexandre-daubois changed the base branch from6.4 to6.3

June 1, 2023 15:10

stof approved these changes

Jun 1, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jun 1, 2023

fabpot approved these changes

Jun 2, 2023

View reviewed changes

fabpot modified the milestones:6.4,6.3

Jun 2, 2023

Copy link

Member

fabpot commentedJun 2, 2023

Thank you@alexandre-daubois.

fabpot merged commit26891af intosymfony:6.3

Jun 2, 2023

alexandre-daubois deleted the fix-null-signals branch

June 2, 2023 13:08

Copy link

Contributor

shyim commentedJun 12, 2023

Can we have a patch version for this fix? This seems to break our Symfony Project in dev-mode as EventDataCollector constructs the listener and then this bug is triggered.

#0 /Users/a.okko/Sites/6.5/testdev2/var/cache/dev_hb12f050958d24ad4316eb5bae74f455a/ContainerNjPmdUq/Shopware_Core_KernelDevDebugContainer.php(35680): Symfony\Component\Messenger\EventListener\StopWorkerOnSignalsListener->__construct() #1 /Users/a.okko/Sites/6.5/testdev2/var/cache/dev_hb12f050958d24ad4316eb5bae74f455a/ContainerNjPmdUq/Shopware_Core_KernelDevDebugContainer.php(13310): ContainerNjPmdUq\Shopware_Core_KernelDevDebugContainer::getMessenger_Listener_StopWorkerSignalsListenerService() #2 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/event-dispatcher/EventDispatcher.php(235): ContainerNjPmdUq\Shopware_Core_KernelDevDebugContainer::ContainerNjPmdUq\{closure}() #3 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/event-dispatcher/EventDispatcher.php(78): Symfony\Component\EventDispatcher\EventDispatcher->sortListeners() #4 /Users/a.okko/Sites/6.5/testdev2/src/Core/Content/Flow/Dispatching/FlowDispatcher.php(98): Symfony\Component\EventDispatcher\EventDispatcher->getListeners() #5 /Users/a.okko/Sites/6.5/testdev2/src/Core/Framework/Webhook/WebhookDispatcher.php(117): Shopware\Core\Content\Flow\Dispatching\FlowDispatcher->getListeners() #6 /Users/a.okko/Sites/6.5/testdev2/src/Core/Framework/Event/NestedEventDispatcher.php(64): Shopware\Core\Framework\Webhook\WebhookDispatcher->getListeners() #7 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php(98): Shopware\Core\Framework\Event\NestedEventDispatcher->getListeners() #8 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php(368): Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->getListeners() #9 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php(177): Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->getListenersWithoutPriority() #10 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/http-kernel/DataCollector/EventDataCollector.php(75): Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->getNotCalledListeners() #11 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/http-kernel/Profiler/Profiler.php(100): Symfony\Component\HttpKernel\DataCollector\EventDataCollector->lateCollect() #12 /Users/a.okko/Sites/6.5/testdev2/vendor/symfony/http-kernel/EventListener/ProfilerListener.php(135): Symfony\Component\HttpKernel\Profiler\Profiler->saveProfile()