Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix Doctrine deprecations#50524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
58e449f tocfc74e6Compare| $schemaManager =$this->createSchemaManager(); | ||
| $comparator =$this->createComparator($schemaManager); | ||
| $schemaDiff =$this->compareSchemas($comparator,$schemaManager->createSchema(),$this->getSchema()); | ||
| $schemaDiff =$this->compareSchemas($comparator,method_exists($schemaManager,'introspectSchema') ?$schemaManager->introspectSchema() :$schemaManager->createSchema(),$this->getSchema()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@nicolas-grekas actually this change deletes all existing tables in the database 😬
Reverting this code-block fixes the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you please open a new issue if you think that this change is wrong (best with a failing example application)? Comments on closed PRs are likely to get lost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
By the way, reading the code I fail to see how this change can change the actual behaviour (the newinstrospectSchema() method callscreateSchema() internally).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@xabbuh yeah, I also thought so, but when I just reverted this code block (not the entire file) it continued to work as expected. But yes, I'll create a follow-up ticket with a reproducible case. Thanks so far 👍😊
Uh oh!
There was an error while loading.Please reload this page.