NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[RemoteEvent][Webhook] Add Sendinblue support#50516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

blaugueux wants to merge1 commit intosymfony:6.4fromblaugueux:sendinblue-webhook

Closed

[RemoteEvent][Webhook] Add Sendinblue support#50516

blaugueux wants to merge1 commit intosymfony:6.4fromblaugueux:sendinblue-webhook

Conversation

Copy link

Contributor

blaugueux commentedMay 31, 2023

Q	A
Branch	6.4
Bug fix	no
New feature	yes
Deprecations	no
Tickets
License	MIT
Doc PR

carsonbot added Status: Needs Review RemoteEvent Webhook labels

May 31, 2023

carsonbot added this to the6.4 milestone

May 31, 2023

blaugueux requested a review fromOskarStark as acode owner

June 4, 2023 07:35

OskarStark reviewed

Jun 4, 2023

View reviewed changes

src/Symfony/Component/Mailer/Bridge/Sendinblue/CHANGELOG.md OutdatedShow resolvedHide resolved

OskarStark reviewed

Jun 4, 2023

View reviewed changes

src/Symfony/Component/Mailer/Bridge/Sendinblue/Webhook/SendinblueRequestParser.php OutdatedShow resolvedHide resolved

[RemoteEvent][Webhook] Add Sendinblue support

f33149f

Copy link

ContributorAuthor

blaugueux commentedJun 19, 2023

@OskarStark Can you please tell me if I need to work on something on this PR?

OskarStark requested a review fromfabpot

June 19, 2023 06:27

Copy link

Contributor

OskarStark commentedJun 19, 2023

Looks good from my side, WDYT@fabpot ?

Copy link

Member

stof commentedJun 19, 2023

Given that Sendinblue has rebranded as Brevo and there is an in-progress PR to create a Brevo bridge using the new domain, I would vote -1 for this PR in its current state. The webhook and remote event integrations should be added to the new bridge, not to the old one.