NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Mailer] [MailPace] Fix undefined array key in errors response#50515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.2fromflofloflo:fix/mailpace-errors-response

Jun 1, 2023

Merged

[Mailer] [MailPace] Fix undefined array key in errors response#50515

nicolas-grekas merged 1 commit intosymfony:6.2fromflofloflo:fix/mailpace-errors-response

Jun 1, 2023

Conversation

Copy link

Contributor

flofloflo commentedMay 31, 2023

Q	A
Branch?	6.2
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	none
License	MIT
Doc PR	-

This PR fixes a bug which occurs when MailPace returns anerrors response instead oferror (seehttps://docs.mailpace.com/reference/responses/ for possible responses).

Without this fix, theerrors response leads to the following exception:ErrorException: Undefined array key "error"

I added two tests to verify that:

responses with multiple errors are returned as readable error message
empty responses generate a readable error message

To fix the bug I added a check for the existence of theerror/errors key in the$result variable and a fallback just in case that both are not present.

carsonbot added Status: Needs Review Bug Mailer labels

May 31, 2023

carsonbot added this to the6.2 milestone

May 31, 2023

Copy link

carsonbot commentedMay 31, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot