Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[SecurityBundle] Fix configuring OIDC user info token handler client#50470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

vincentchalamon
Copy link
Contributor

@vincentchalamonvincentchalamon commentedMay 30, 2023•
edited
Loading

QA
Branch?6.3
Bug fix?no
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRsymfony/symfony-docs#18354

Cf.#50453 (comment)

@vincentchalamonvincentchalamonforce-pushed thefix/security/oidc_user_info-token_handler-client branch 7 times, most recently fromdab1d31 to8e74520CompareMay 30, 2023 12:11
@nicolas-grekasnicolas-grekas changed the title[Security] OIDC user info token handler client[Security] Fix configuring OIDC user info token handler clientMay 30, 2023
@nicolas-grekasnicolas-grekas changed the title[Security] Fix configuring OIDC user info token handler client[SecurityBundle] Fix configuring OIDC user info token handler clientMay 30, 2023
@nicolas-grekasnicolas-grekasforce-pushed thefix/security/oidc_user_info-token_handler-client branch from8e74520 to8b7fdc1CompareMay 30, 2023 14:30
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I tweaked the implementation a bit, see
https://github.com/symfony/symfony/compare/8e7452011403b4bbe67a4d2abd12dde3df95f0c3..8b7fdc108237bd8e88c59aa0282aa6d36d9ae7ad

TL;DR, thebase_uri option is required, and theclient option can be used optionally to configure any other options.

vincentchalamon reacted with thumbs up emoji
@vincentchalamonvincentchalamonforce-pushed thefix/security/oidc_user_info-token_handler-client branch from402101b to86ab255CompareMay 30, 2023 14:42
@nicolas-grekasnicolas-grekasforce-pushed thefix/security/oidc_user_info-token_handler-client branch from86ab255 to23c9e17CompareMay 30, 2023 14:46
@nicolas-grekas
Copy link
Member

Thank you@vincentchalamon.

@nicolas-grekasnicolas-grekas merged commit5c46e7e intosymfony:6.3May 30, 2023
@vincentchalamonvincentchalamon deleted the fix/security/oidc_user_info-token_handler-client branchMay 30, 2023 14:47
aegypius added a commit to aegypius/symfony that referenced this pull requestMay 30, 2023
aegypius added a commit to aegypius/symfony that referenced this pull requestMay 30, 2023
@fabpotfabpot mentioned this pull requestMay 30, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@mtarldmtarldmtarld left review comments

@wouterjwouterjAwaiting requested review from wouterj

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

4 participants
@vincentchalamon@nicolas-grekas@mtarld@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp