NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Hide definitions bearing the`container.excluded` tag#50452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

chalasr merged 1 commit intosymfony:6.2fromMyks92:fix-contaier-debug

May 29, 2023

Merged

Hide definitions bearing the`container.excluded` tag#50452

chalasr merged 1 commit intosymfony:6.2fromMyks92:fix-contaier-debug

May 29, 2023

Conversation

Copy link

Contributor

Myks92 commentedMay 27, 2023

Q	A
Branch?	6.2
Bug fix?	yes
New feature?	no
	Depreciation?
Tickets	Fix#50417
License	MIT
Doc PR	-

Normally I test whether the exclusion rules from the service container of my bundles work correctly by just using thedebug:container command and looking whether my excluded services occur in the last.
However, due to the latest changes in#46279 all folders and subfulders (excluded or not) are always in this list.

You need to open the definition to see if it was excluded:

For example,Command,Query,Entity are folders, but they are specified as services in the container.

This PR fixes this problem to ignore definitions bearing the container.excluded tag if those are to be hidden for Descriptors:JsonDescriptor,MarkdownDescriptor,TextDescriptor andXmlDescriptor.

After fixes problem:

carsonbot added Status: Needs Review Bug labels

May 27, 2023

carsonbot added this to the6.2 milestone

May 27, 2023

Copy link

carsonbot commentedMay 27, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot