Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (seehttps://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
• Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@zoidbergx it looks like you merged your non-rebased remote branch instead of forcing the push after the rebase was done, which means your PR contains duplicate commits in its history and a merge commit.

bug fix: yes in the description looks wrong to me (in general, your change cannot be both a bug fix and a new feature)

@stof >bug fix: yes in the description looks wrong to me (in general, your change cannot be both a bug fix and a new feature)

yeah, for me it was a little bit of both as the current implementation could lead into a buggy cache but it may be more like a feature to have a garbage collector for Redis